Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add replicaset and replicationController kinds in podsecurity validation #5336

Merged
merged 2 commits into from
Nov 14, 2022

Conversation

prateekpandey14
Copy link
Contributor

Signed-off-by: prateekpandey14 prateek.pandey@nirmata.com

Explanation

Add missing Replicaset and Replicationcontroller kinds while validating PodSecurity policies added as part of PR
#4975

…lidation

Signed-off-by: prateekpandey14 <prateek.pandey@nirmata.com>
Copy link
Member

@realshuting realshuting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test?

@prateekpandey14
Copy link
Contributor Author

Test?

@realshuting we are already have kuttl test as part of changes in #4975.

@codecov
Copy link

codecov bot commented Nov 14, 2022

Codecov Report

Merging #5336 (846868f) into main (86fc537) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #5336   +/-   ##
=======================================
  Coverage   36.03%   36.03%           
=======================================
  Files         167      167           
  Lines       18913    18913           
=======================================
  Hits         6815     6815           
  Misses      11309    11309           
  Partials      789      789           
Impacted Files Coverage Δ
pkg/engine/validation.go 59.49% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@eddycharly eddycharly merged commit f1935a4 into kyverno:main Nov 14, 2022
@prateekpandey14 prateekpandey14 deleted the fix-ps-validation branch November 15, 2022 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants