-
Notifications
You must be signed in to change notification settings - Fork 774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add some missing options in cleanup helm chart #5351
Conversation
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Codecov Report
@@ Coverage Diff @@
## main #5351 +/- ##
=======================================
Coverage 36.03% 36.03%
=======================================
Files 167 167
Lines 18913 18913
=======================================
Hits 6815 6815
Misses 11309 11309
Partials 789 789 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Release notes?
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Done |
Would it be possible to get CI values added for Helm chart to stress the cleanup controller resources? |
@treydock it will be my next PR |
Explanation
This PR adds some missing options in cleanup helm chart: