feat: add tracing middleware #5397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Codecov Report
@@ Coverage Diff @@
## main #5397 +/- ##
==========================================
- Coverage 36.37% 36.30% -0.07%
==========================================
Files 169 170 +1
Lines 19036 19072 +36
==========================================
Hits 6924 6924
- Misses 11320 11356 +36
Partials 792 792
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
realshuting
approved these changes
Nov 18, 2022
| } | ||
|
|
||
| // Span executes function doFn inside new span with `operationName` name and hooking as child to a span found within given context if any. | ||
| func Span1[T any](ctx context.Context, tracerName string, operationName string, doFn func(context.Context, trace.Span) T, opts ...trace.SpanStartOption) T { |
There was a problem hiding this comment.
Maybe rename it to SpanAny()?
There was a problem hiding this comment.
SpanAny does not make sense, 1 here refers to the number of element in the return statement (we could have Span2, Span3, etc... if we want to support funcs that return multiple values).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR adds a tracing middleware to all admission request handlers.
Every request will have a trace starting from the beginning of the request handling chain.