Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: introduce cmd internal package #5404

Merged
merged 9 commits into from
Nov 18, 2022

Conversation

eddycharly
Copy link
Member

Signed-off-by: Charles-Edouard Brétéché charles.edouard@nirmata.com

Explanation

This PR introduces an internal package for cmd.
This package contains elements that are used across multiple binaries:

  • logging
  • profiling
  • maxprocs
  • version
  • common flags

This will help having consistent flags/features across binaries.

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Merging #5404 (28163dd) into main (1b307ff) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #5404   +/-   ##
=======================================
  Coverage   36.30%   36.30%           
=======================================
  Files         170      170           
  Lines       19072    19072           
=======================================
  Hits         6924     6924           
  Misses      11356    11356           
  Partials      792      792           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

cmd/internal/profiling.go Outdated Show resolved Hide resolved
cmd/internal/profiling.go Outdated Show resolved Hide resolved
eddycharly and others added 7 commits November 17, 2022 23:28
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Signed-off-by: Charles-Edouard Brétéché <charled.breteche@gmail.com>
Copy link
Member

@realshuting realshuting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

This is clear!

@realshuting realshuting merged commit 4bdd45c into kyverno:main Nov 18, 2022
@eddycharly eddycharly deleted the cmd-internal branch November 18, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants