Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: split argocd lab into multiple steps #5410

Merged
merged 6 commits into from
Nov 22, 2022

Conversation

eddycharly
Copy link
Member

Explanation

This PR splits argocd lab into multiple steps.
This will help reusing the lab and deploy core components with argocd but kyverno with helm.

eddycharly and others added 3 commits November 18, 2022 10:46
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Merging #5410 (e4179e2) into main (f70c6ef) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #5410   +/-   ##
=======================================
  Coverage   36.43%   36.43%           
=======================================
  Files         171      171           
  Lines       19104    19104           
=======================================
  Hits         6961     6961           
  Misses      11345    11345           
  Partials      798      798           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more


readonly SRC=$(dirname "$0")

$SRC/common-steps.sh
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💬 14 similar findings have been found in this PR


SC2086: Double quote to prevent globbing and word splitting.


🔎 Expand here to view all instances of this finding
File Path Line Number
scripts/labs/argocd/kind-argo.sh 7
scripts/labs/argocd/kind-argo.sh 8
scripts/labs/argocd/kind-argo.sh 9
scripts/labs/argocd/kind-argo.sh 10
scripts/labs/argocd/kind-argo.sh 11
scripts/labs/argocd/common-steps.sh 7
scripts/labs/argocd/common-steps.sh 8
scripts/labs/argocd/common-steps.sh 9
scripts/labs/argocd/common-steps.sh 10
scripts/labs/argocd/common-steps.sh 11

Showing 10 of 14 findings. Visit the Lift Web Console to see all.


Fix rate: 44%


ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage
@sonatype-lift ignore Leave out the above finding from this PR
@sonatype-lift ignoreall Leave out all the existing findings from this PR
@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.


Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]


set -e

readonly SRC=$(dirname "$0")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💬 2 similar findings have been found in this PR


SC2155: Declare and assign separately to avoid masking return values.


🔎 Expand here to view all instances of this finding
File Path Line Number
scripts/labs/argocd/kind-argo.sh 5
scripts/labs/argocd/common-steps.sh 5

Visit the Lift Web Console to find more details in your report.


Fix rate: 43%


ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage
@sonatype-lift ignore Leave out the above finding from this PR
@sonatype-lift ignoreall Leave out all the existing findings from this PR
@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.


Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

eddycharly and others added 3 commits November 18, 2022 17:32
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
@eddycharly eddycharly merged commit 28619ce into kyverno:main Nov 22, 2022
@eddycharly eddycharly deleted the refator-lab branch November 22, 2022 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants