Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make traces better #5412

Merged
merged 2 commits into from
Nov 20, 2022
Merged

feat: make traces better #5412

merged 2 commits into from
Nov 20, 2022

Conversation

eddycharly
Copy link
Member

@eddycharly eddycharly commented Nov 18, 2022

Signed-off-by: Charles-Edouard Brétéché charles.edouard@nirmata.com

Explanation

This PR makes traces better:

  • better use of tracer info
  • better operation names
  • record errors

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Merging #5412 (8e3e20c) into main (4bdd45c) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #5412      +/-   ##
==========================================
- Coverage   36.30%   36.29%   -0.01%     
==========================================
  Files         170      171       +1     
  Lines       19072    19076       +4     
==========================================
  Hits         6924     6924              
- Misses      11356    11360       +4     
  Partials      792      792              
Impacted Files Coverage Δ
pkg/webhooks/handlers/admission.go 0.00% <0.00%> (ø)
pkg/webhooks/handlers/dump.go 46.96% <0.00%> (ø)
pkg/webhooks/handlers/filter.go 0.00% <0.00%> (ø)
pkg/webhooks/handlers/metrics.go 0.00% <0.00%> (ø)
pkg/webhooks/handlers/protect.go 0.00% <0.00%> (ø)
pkg/webhooks/handlers/trace.go 0.00% <0.00%> (ø)
pkg/webhooks/handlers/utils.go 0.00% <0.00%> (ø)
pkg/webhooks/handlers/verify.go 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
@eddycharly eddycharly merged commit ce94187 into kyverno:main Nov 20, 2022
@eddycharly eddycharly deleted the better-traces branch November 20, 2022 13:43
@eddycharly eddycharly restored the better-traces branch November 21, 2022 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants