Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix request.operation in globalValues is always set to CREATE #5423

Merged
merged 4 commits into from
Nov 22, 2022

Conversation

cleverhu
Copy link
Contributor

@cleverhu cleverhu commented Nov 21, 2022

Explanation

Related issue

#5396

Milestone of this PR

What type of PR is this

/kind bug

Proposed Changes

fix request.operation in globalValues is always set to CREATE

Proof Manifests

Checklist

  • I have read the contributing guidelines.
  • I have read the PR documentation guide and followed the process including adding proof manifests to this PR.
  • This is a bug fix and I have added unit tests that prove my fix is effective.
  • This is a feature and I have added CLI tests that are applicable.
  • My PR needs to be cherry picked to a specific release branch which is .
  • My PR contains new or altered behavior to Kyverno and
    • CLI support should be added and my PR doesn't contain that functionality.
    • I have added or changed the documentation myself in an existing PR and the link is:
    • I have raised an issue in kyverno/website to track the documentation update and the link is:

Further Comments

Signed-off-by: cleverhu <shouping.hu@daocloud.io>
@welcome
Copy link

welcome bot commented Nov 21, 2022

Thanks for opening your first Pull Request here! Please check out our Contributing guidelines and confirm that you Signed off.

@chipzoller
Copy link
Member

chipzoller commented Nov 21, 2022

Does this address a current issue? Please abide by and complete the full PR template.

@codecov
Copy link

codecov bot commented Nov 21, 2022

Codecov Report

Merging #5423 (23a01e3) into main (2765ab1) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #5423      +/-   ##
==========================================
- Coverage   36.44%   36.43%   -0.01%     
==========================================
  Files         171      171              
  Lines       19102    19104       +2     
==========================================
  Hits         6961     6961              
- Misses      11343    11345       +2     
  Partials      798      798              
Impacted Files Coverage Δ
cmd/cli/kubectl-kyverno/utils/common/common.go 14.77% <0.00%> (-0.04%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vyankyGH vyankyGH self-assigned this Nov 21, 2022
@vyankyGH vyankyGH added this to the Kyverno Release 1.9.0 milestone Nov 21, 2022
@vyankyGH
Copy link
Contributor

Does this address a current issue? Please abide by and complete the full PR template.

#5396

@cleverhu
Copy link
Contributor Author

Does this address a current issue? Please abide by and complete the full PR template.

#5396

Yes, thank you for your reply.

@vyankyGH vyankyGH enabled auto-merge (squash) November 22, 2022 11:45
@vyankyGH vyankyGH merged commit 8a09d76 into kyverno:main Nov 22, 2022
@welcome
Copy link

welcome bot commented Nov 22, 2022

Congratulations! 🎉

Great job merging your first Pull Request here! How awesome! If you are new to this project, feel free to join our Slack community
200w

@chipzoller
Copy link
Member

A CLI test for this is warranted.

@cleverhu
Copy link
Contributor Author

A CLI test for this is warranted.

I found it hard to add for me:(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants