-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix request.operation in globalValues is always set to CREATE #5423
fix request.operation in globalValues is always set to CREATE #5423
Conversation
Signed-off-by: cleverhu <shouping.hu@daocloud.io>
Thanks for opening your first Pull Request here! Please check out our Contributing guidelines and confirm that you Signed off. |
Does this address a current issue? Please abide by and complete the full PR template. |
Codecov Report
@@ Coverage Diff @@
## main #5423 +/- ##
==========================================
- Coverage 36.44% 36.43% -0.01%
==========================================
Files 171 171
Lines 19102 19104 +2
==========================================
Hits 6961 6961
- Misses 11343 11345 +2
Partials 798 798
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Yes, thank you for your reply. |
Congratulations! 🎉Great job merging your first Pull Request here! How awesome! If you are new to this project, feel free to join our Slack community |
A CLI test for this is warranted. |
I found it hard to add for me:( |
Explanation
Related issue
#5396
Milestone of this PR
What type of PR is this
/kind bug
Proposed Changes
fix request.operation in globalValues is always set to CREATE
Proof Manifests
Checklist
Further Comments