-
Notifications
You must be signed in to change notification settings - Fork 776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: improve instrumented clients code and support dynamic/metadata client #5428
Conversation
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Codecov Report
@@ Coverage Diff @@
## main #5428 +/- ##
=======================================
Coverage 36.43% 36.44%
=======================================
Files 171 171
Lines 19104 19102 -2
=======================================
Hits 6961 6961
+ Misses 11345 11343 -2
Partials 798 798
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
logger = logger.WithName("kyverno-client") | ||
logger.Info("create kyverno client...", "kubeconfig", kubeconfig, "qps", clientRateLimitQPS, "burst", clientRateLimitBurst) | ||
client, err := kyverno.NewForConfig(CreateClientConfig(logger), opts...) | ||
checkError(logger, err, "failed to create kubernetes client") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.."failed to create kyverno client"..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, will fix in the next PR !
Explanation
This PR improve instrumented clients code:
It also adds support for dynamic and metadata client.