Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add logging support to instrumented clients #5438

Merged
merged 5 commits into from
Nov 22, 2022

Conversation

eddycharly
Copy link
Member

Explanation

This PR adds logging support to instrumented clients.

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Merging #5438 (3dbb757) into main (4ccec04) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #5438   +/-   ##
=======================================
  Coverage   36.41%   36.41%           
=======================================
  Files         171      171           
  Lines       19086    19086           
=======================================
  Hits         6951     6951           
  Misses      11337    11337           
  Partials      798      798           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@realshuting realshuting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went through pkg/clients/dynamic/client.go and pkg/clients/metadata/client.go, look good!

@realshuting realshuting self-assigned this Nov 22, 2022
Signed-off-by: Charles-Edouard Brétéché <charled.breteche@gmail.com>
@eddycharly eddycharly enabled auto-merge (squash) November 22, 2022 14:57
@eddycharly eddycharly merged commit ecbdaae into kyverno:main Nov 22, 2022
@eddycharly eddycharly deleted the instrument-logging branch November 22, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants