feat: improve handlers tracing code #5442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
realshuting
approved these changes
Nov 23, 2022
Comment on lines
+30
to
+35
| // ResourceNameKey = attribute.Key("admission.resource.name") | ||
| // ResourceNamespaceKey = attribute.Key("admission.resource.namespace") | ||
| // ResourceGroupKey = attribute.Key("admission.resource.group") | ||
| // ResourceVersionKey = attribute.Key("admission.resource.version") | ||
| // ResourceKindKey = attribute.Key("admission.resource.kind") | ||
| // ResourceUidKey = attribute.Key("admission.resource.uid") |
Codecov Report
@@ Coverage Diff @@
## main #5442 +/- ##
==========================================
+ Coverage 36.41% 36.44% +0.02%
==========================================
Files 171 172 +1
Lines 19086 19075 -11
==========================================
Hits 6951 6951
+ Misses 11337 11326 -11
Partials 798 798
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
prateekpandey14
approved these changes
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR improves handlers tracing code: