-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use admission review v1 #5464
Conversation
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Codecov Report
@@ Coverage Diff @@
## main #5464 +/- ##
==========================================
+ Coverage 36.42% 36.44% +0.01%
==========================================
Files 171 171
Lines 19133 19137 +4
==========================================
+ Hits 6970 6974 +4
Misses 11371 11371
Partials 792 792
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to test the upgrade once to see every thing is seamless ?. Ideally it should work but just in case.
Signed-off-by: Charles-Edouard Brétéché <charled.breteche@gmail.com>
Signed-off-by: Charles-Edouard Brétéché <charled.breteche@gmail.com>
Agreed, we need to test the upgrade and make sure it works as expected. |
Signed-off-by: Charles-Edouard Brétéché <charled.breteche@gmail.com>
@realshuting I'm trying right now. |
@realshuting @prateekpandey14 worked like a charm :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Explanation
This PR uses admission review v1 instead of v1beta1.
v1 requires: