feat: create a policy utils package #5473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Codecov Report
@@ Coverage Diff @@
## main #5473 +/- ##
=======================================
Coverage 36.42% 36.42%
=======================================
Files 172 172
Lines 19087 19087
=======================================
Hits 6952 6952
Misses 11340 11340
Partials 795 795 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| @@ -97,13 +96,9 @@ kyverno oci pull -i <imgref> -d policies`, | |||
| return fmt.Errorf("unmarshaling layer blob: %v", err) | |||
| } | |||
| for _, policy := range policies { | |||
| policyJsonBytes, err := json.Marshal(policy) | |||
| policyBytes, err := policyutils.ToYaml(policy) | |||
There was a problem hiding this comment.
can we add a comment here , since function name says ToYaml but we doing obj>json>yaml ?
There was a problem hiding this comment.
@prateekpandey14 done.
There was a problem hiding this comment.
BTW, I added the comment on the ToYaml func, not here.
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
vyankyGH
approved these changes
Nov 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Charles-Edouard Brétéché charles.edouard@nirmata.com
Explanation
This PR creates a policy utils package.
We manipulate policies a lot and this package will contain policy manipulation code we use often.
For now I added functions to marshal policies into json/yaml.