Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: metrics configuration code #5475

Merged
merged 3 commits into from
Nov 25, 2022

Conversation

eddycharly
Copy link
Member

Explanation

This PR refactors metrics configuration code:

  • introduces an interface
  • adds a constructor
  • removes unnecessary fields
  • adds support in internal cmd package

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Merging #5475 (f81b9ae) into main (4984c5c) will increase coverage by 0.01%.
The diff coverage is 3.77%.

@@            Coverage Diff             @@
##             main    #5475      +/-   ##
==========================================
+ Coverage   36.42%   36.43%   +0.01%     
==========================================
  Files         172      171       -1     
  Lines       19087    19078       -9     
==========================================
  Hits         6952     6952              
+ Misses      11340    11331       -9     
  Partials      795      795              
Impacted Files Coverage Δ
pkg/config/config.go 0.00% <ø> (ø)
pkg/config/metricsconfig.go 0.00% <0.00%> (ø)
pkg/webhooks/resource/fake.go 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@eddycharly eddycharly enabled auto-merge (squash) November 25, 2022 12:46
@eddycharly eddycharly merged commit e03f481 into kyverno:main Nov 25, 2022
@eddycharly eddycharly deleted the metrics-config branch November 25, 2022 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants