feat: add dynamic client support to internal cmd package #5477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Codecov Report
@@ Coverage Diff @@
## main #5477 +/- ##
=======================================
Coverage 36.44% 36.44%
=======================================
Files 171 171
Lines 19141 19141
=======================================
Hits 6975 6975
Misses 11374 11374
Partials 792 792 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
realshuting
previously approved these changes
Nov 28, 2022
cmd/internal/client.go
Outdated
|
|
||
| func CreateDClient(logger logr.Logger, ctx context.Context, dyn dynamic.Interface, kube kubernetes.Interface, resync time.Duration) dclient.Interface { | ||
| logger = logger.WithName("d-client") | ||
| logger.Info("create d client...", "kubeconfig", kubeconfig, "qps", clientRateLimitQPS, "burst", clientRateLimitBurst) |
There was a problem hiding this comment.
Maybe good to change to "create dynamic client...".
There was a problem hiding this comment.
Yeah, but we already have a dynamic client thing, the one from kube ;)
There was a problem hiding this comment.
Ops, I did not check that. Any other suggestions?
There was a problem hiding this comment.
I was short on ideas here :(
There was a problem hiding this comment.
But I definitely agree the name sucks.
There was a problem hiding this comment.
"the Kyverno dynamic client"? At least if differs from the other one.
Signed-off-by: shuting <shutting06@gmail.com>
realshuting
previously approved these changes
Nov 28, 2022
Signed-off-by: Charles-Edouard Brétéché <charled.breteche@gmail.com>
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
realshuting
reviewed
Nov 29, 2022
Signed-off-by: shuting <shutting06@gmail.com>
realshuting
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR adds dynamic client support to internal cmd package.