chore: refactor metrics namespace check #5489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Codecov Report
@@ Coverage Diff @@
## main #5489 +/- ##
==========================================
- Coverage 36.54% 36.52% -0.03%
==========================================
Files 171 171
Lines 19095 19107 +12
==========================================
Hits 6979 6979
- Misses 11324 11336 +12
Partials 792 792
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
realshuting
reviewed
Nov 28, 2022
| // CheckNamespace returns `true` if the namespace has to be considered | ||
| func (mcd *metricsConfig) CheckNamespace(namespace string) bool { | ||
| // TODO(eddycharly): check we actually need `"-"` | ||
| if namespace == "" || namespace == "-" { |
There was a problem hiding this comment.
What does - mean? The empty or default namespace?
There was a problem hiding this comment.
Looks like it's empty.
eddycharly
commented
Nov 28, 2022
| @@ -23,24 +21,13 @@ func registerPolicyExecutionDurationMetric( | |||
| ruleType metrics.RuleType, | |||
| ruleExecutionCause metrics.RuleExecutionCause, | |||
| ruleExecutionLatency float64, | |||
| ) error { | |||
| ) { | |||
| if policyType == metrics.Cluster { | |||
There was a problem hiding this comment.
cc @realshuting we seem to use it for clustered resources.
realshuting
approved these changes
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Charles-Edouard Brétéché charles.edouard@nirmata.com
Explanation
This PR refactors metrics namespace check.
Factorises out the code and removes unnecessary errors when returning always
nil.