Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add webhook type to admission metrics #5493

Merged
merged 3 commits into from
Nov 30, 2022

Conversation

eddycharly
Copy link
Member

Explanation

This PR adds webhook type to admission metrics.

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
@codecov
Copy link

codecov bot commented Nov 28, 2022

Codecov Report

Merging #5493 (d179ba3) into main (c3be9e3) will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #5493      +/-   ##
==========================================
+ Coverage   36.43%   36.44%   +0.01%     
==========================================
  Files         171      171              
  Lines       19145    19138       -7     
==========================================
  Hits         6975     6975              
+ Misses      11378    11371       -7     
  Partials      792      792              
Impacted Files Coverage Δ
pkg/webhooks/handlers/metrics.go 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

realshuting
realshuting previously approved these changes Nov 29, 2022
@realshuting realshuting enabled auto-merge (squash) November 29, 2022 09:19
@realshuting realshuting self-assigned this Nov 29, 2022
@realshuting
Copy link
Member

@eddycharly - need to resolve conflicts.

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
@realshuting realshuting merged commit ff9ba81 into kyverno:main Nov 30, 2022
@eddycharly eddycharly deleted the metrics-attributes branch November 30, 2022 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants