chore: stop using set-output in gh actions #5500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Codecov Report
@@ Coverage Diff @@
## main #5500 +/- ##
=======================================
Coverage 36.42% 36.42%
=======================================
Files 171 171
Lines 19133 19133
=======================================
Hits 6970 6970
Misses 11371 11371
Partials 792 792 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
samj1912
reviewed
Nov 29, 2022
.github/workflows/release.yaml
Outdated
| @@ -59,7 +59,7 @@ jobs: | |||
| steps: | |||
| - name: Set version | |||
| id: version | |||
| run: echo ::set-output name=version::${GITHUB_REF#refs/*/} | |||
| run: echo version=${GITHUB_REF#refs/*/} >> $GITHUB_OUTPUT | |||
There was a problem hiding this comment.
Should all of these be surrounded by quotes to avoid any space related issues?
There was a problem hiding this comment.
TBH I have no idea, I can add quotes it shouldn't hurt.
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
samj1912
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Charles-Edouard Brétéché charles.edouard@nirmata.com
Explanation
This PR stops using
set-outputin gh actions (is deprecated).See https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/