chore: improve cleanup controller #5509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Codecov Report
@@ Coverage Diff @@
## main #5509 +/- ##
=======================================
Coverage 36.44% 36.44%
=======================================
Files 171 171
Lines 19137 19137
=======================================
Hits 6974 6974
Misses 11371 11371
Partials 792 792 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
vyankyGH
previously approved these changes
Nov 30, 2022
|
@eddycharly need to resolve conflicts. |
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
|
Thanks @vyankyGH, done. |
realshuting
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR improves cleanup controller by factorising some code.