refactor: make policy context immutable and fields private #5523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
eddycharly
commented
Dec 1, 2022
Codecov Report
@@ Coverage Diff @@
## main #5523 +/- ##
==========================================
- Coverage 36.52% 36.36% -0.16%
==========================================
Files 171 171
Lines 19238 19261 +23
==========================================
- Hits 7026 7005 -21
- Misses 11416 11460 +44
Partials 796 796
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
realshuting
reviewed
Dec 2, 2022
Comment on lines
-511
to
-513
| ExcludeGroupRole: []string{}, | ||
| ExcludeResourceFunc: func(s1, s2, s3 string) bool { | ||
| return false |
There was a problem hiding this comment.
What are these two vars? Doesn't seem to be needed.
There was a problem hiding this comment.
What do you mean ?
This code was removed.
There was a problem hiding this comment.
Just questioning why they were added before, nothing to change :)
realshuting
approved these changes
Dec 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR makes policy context immutable and fields private.