-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: split CLI jp command #5566
Conversation
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Codecov Report
@@ Coverage Diff @@
## main #5566 +/- ##
=======================================
Coverage 34.62% 34.62%
=======================================
Files 190 190
Lines 21106 21106
=======================================
Hits 7307 7307
Misses 12986 12986
Partials 813 813 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
We can start with one query per command IMO. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you look at sonatype-lift comments?
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
* refactor: split CLI jp command Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> * fix sonatype comments Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> * fix Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> Co-authored-by: shuting <shuting@nirmata.com> Co-authored-by: Vyankatesh Kudtarkar <vyankateshkd@gmail.com> Signed-off-by: Md Sahil <Mohdssahil1@gmail.com>
* refactor: split CLI jp command Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> * fix sonatype comments Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> * fix Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> Co-authored-by: shuting <shuting@nirmata.com> Co-authored-by: Vyankatesh Kudtarkar <vyankateshkd@gmail.com> Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
* refactor: split CLI jp command Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> * fix sonatype comments Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> * fix Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> Co-authored-by: shuting <shuting@nirmata.com> Co-authored-by: Vyankatesh Kudtarkar <vyankateshkd@gmail.com> Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: Charles-Edouard Brétéché charles.edouard@nirmata.com
Explanation
This PR refactors the
jp
command into sub commands:parse
parses a jmespath expression and shows the ASTfunction
shows functions informationsquery
runs queries against objectsOpen questions:
With this change, the query being executed is written in the console output, this can be a problem if the tool is used in automation: