New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement quantity comparison #558

Merged

realshuting merged 2 commits into master from 428_quantity

Dec 16, 2019

Member

realshuting commented Dec 13, 2019

Fix #428.

In order to handle quantity comparison (pattern in a rule is defined with string, e.g. "1Gi"), we first parse the pattern:

if it's with type quantity, then compare by the quantities
if it's a normal string, then a wildcard match

realshuting added 2 commits

December 13, 2019 13:17


          implement quantity comparison

0969aa9


          update test

5ced240

realshuting requested a review from shivdudhani

December 13, 2019 21:34

shivdudhani approved these changes

View reviewed changes

realshuting merged commit 4149d70 into master

realshuting deleted the 428_quantity branch

December 16, 2019 23:53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment