Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use helm values for CRD labels #5594

Merged
merged 2 commits into from
Dec 7, 2022
Merged

use helm values for CRD labels #5594

merged 2 commits into from
Dec 7, 2022

Conversation

bakito
Copy link
Contributor

@bakito bakito commented Dec 6, 2022

Signed-off-by: bakito github@bakito.ch

Explanation

This PR changes the values of the CRD labels to be generated in sync with the rest of the resources.
When installed with ArgoCD the previous version got generated warning if the release name in ArgoCD was not 'kyverno'.

Related issue

none

Milestone of this PR

/milestone 1.9.0

What type of PR is this

/kind cleanup

Proposed Changes

The PR updates the labels of CRD to the current values from helm. Which is in sync with the rest of the reources.

Kubernetes resource

apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
  labels:
    app.kubernetes.io/component: kyverno
    app.kubernetes.io/instance: {{ .Release.Name }}
    app.kubernetes.io/name: {{ template "kyverno.name" . }}
    app.kubernetes.io/part-of: {{ template "kyverno.name" . }}
    app.kubernetes.io/version: '{{.Chart.AppVersion}}'

Checklist

  • I have read the contributing guidelines.
  • I have read the PR documentation guide and followed the process including adding proof manifests to this PR.
  • This is a bug fix and I have added unit tests that prove my fix is effective.
  • This is a feature and I have added CLI tests that are applicable.
  • My PR needs to be cherry picked to a specific release branch which is .
  • My PR contains new or altered behavior to Kyverno and
    • CLI support should be added and my PR doesn't contain that functionality.
    • I have added or changed the documentation myself in an existing PR and the link is:
    • I have raised an issue in kyverno/website to track the documentation update and the link is:

@eddycharly
Copy link
Member

@bakito you need to do that in the Makefile, this is generated code.

@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Merging #5594 (3863aeb) into main (6cdc3f4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #5594   +/-   ##
=======================================
  Coverage   36.51%   36.51%           
=======================================
  Files         173      173           
  Lines       19250    19250           
=======================================
  Hits         7029     7029           
  Misses      11430    11430           
  Partials      791      791           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bakito
Copy link
Contributor Author

bakito commented Dec 6, 2022

@bakito you need to do that in the Makefile, this is generated code.

@eddycharly thx for the hint, I changed it

Signed-off-by: bakito <github@bakito.ch>
Copy link
Member

@eddycharly eddycharly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for working on this !

@eddycharly eddycharly enabled auto-merge (squash) December 7, 2022 13:41
@eddycharly eddycharly merged commit 616d0d3 into kyverno:main Dec 7, 2022
MdSahil-oss pushed a commit to MdSahil-oss/kyverno that referenced this pull request Dec 29, 2022
Signed-off-by: bakito <github@bakito.ch>

Signed-off-by: bakito <github@bakito.ch>
Co-authored-by: Charles-Edouard Brétéché <charled.breteche@gmail.com>
Signed-off-by: Md Sahil <Mohdssahil1@gmail.com>
MdSahil-oss pushed a commit to MdSahil-oss/kyverno that referenced this pull request Jan 11, 2023
Signed-off-by: bakito <github@bakito.ch>

Signed-off-by: bakito <github@bakito.ch>
Co-authored-by: Charles-Edouard Brétéché <charled.breteche@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
MdSahil-oss pushed a commit to MdSahil-oss/kyverno that referenced this pull request Jan 11, 2023
Signed-off-by: bakito <github@bakito.ch>

Signed-off-by: bakito <github@bakito.ch>
Co-authored-by: Charles-Edouard Brétéché <charled.breteche@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants