-
Notifications
You must be signed in to change notification settings - Fork 776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use helm values for CRD labels #5594
Conversation
@bakito you need to do that in the Makefile, this is generated code. |
Codecov Report
@@ Coverage Diff @@
## main #5594 +/- ##
=======================================
Coverage 36.51% 36.51%
=======================================
Files 173 173
Lines 19250 19250
=======================================
Hits 7029 7029
Misses 11430 11430
Partials 791 791 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@eddycharly thx for the hint, I changed it |
Signed-off-by: bakito <github@bakito.ch>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for working on this !
Signed-off-by: bakito <github@bakito.ch> Signed-off-by: bakito <github@bakito.ch> Co-authored-by: Charles-Edouard Brétéché <charled.breteche@gmail.com> Signed-off-by: Md Sahil <Mohdssahil1@gmail.com>
Signed-off-by: bakito <github@bakito.ch> Signed-off-by: bakito <github@bakito.ch> Co-authored-by: Charles-Edouard Brétéché <charled.breteche@gmail.com> Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: bakito <github@bakito.ch> Signed-off-by: bakito <github@bakito.ch> Co-authored-by: Charles-Edouard Brétéché <charled.breteche@gmail.com> Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: bakito github@bakito.ch
Explanation
This PR changes the values of the CRD labels to be generated in sync with the rest of the resources.
When installed with ArgoCD the previous version got generated warning if the release name in ArgoCD was not 'kyverno'.
Related issue
none
Milestone of this PR
/milestone 1.9.0
What type of PR is this
Proposed Changes
The PR updates the labels of CRD to the current values from helm. Which is in sync with the rest of the reources.
Kubernetes resource
Checklist