Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: registry client #5596

Merged
merged 8 commits into from
Dec 7, 2022
Merged

Conversation

eddycharly
Copy link
Member

Signed-off-by: Charles-Edouard Brétéché charles.edouard@nirmata.com

Explanation

This PR refactors registry client:

  • removes the global default client
  • refactors creation

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Merging #5596 (db4f7a2) into main (616d0d3) will decrease coverage by 0.03%.
The diff coverage is 37.06%.

❗ Current head db4f7a2 differs from pull request most recent head 9e970db. Consider uploading reports for the commit 9e970db to get more accurate results

@@            Coverage Diff             @@
##             main    #5596      +/-   ##
==========================================
- Coverage   36.51%   36.47%   -0.04%     
==========================================
  Files         173      174       +1     
  Lines       19250    19254       +4     
==========================================
- Hits         7029     7023       -6     
- Misses      11430    11440      +10     
  Partials      791      791              
Impacted Files Coverage Δ
pkg/background/generate/generate.go 0.00% <0.00%> (ø)
pkg/engine/background.go 0.00% <0.00%> (ø)
pkg/engine/generation.go 0.00% <0.00%> (ø)
pkg/engine/imageVerifyValidate.go 11.25% <0.00%> (ø)
pkg/policy/apply.go 0.00% <0.00%> (ø)
pkg/policy/existing.go 0.00% <0.00%> (ø)
pkg/policy/policy_controller.go 7.69% <0.00%> (-0.03%) ⬇️
pkg/policy/updaterequest.go 0.00% <0.00%> (ø)
pkg/registryclient/utils.go 0.00% <0.00%> (ø)
pkg/webhooks/resource/generation/generation.go 0.00% <0.00%> (ø)
... and 10 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

eddycharly and others added 5 commits December 6, 2022 21:57
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
@eddycharly eddycharly marked this pull request as ready for review December 7, 2022 10:46
@realshuting realshuting merged commit 7219b4f into kyverno:main Dec 7, 2022
MdSahil-oss pushed a commit to MdSahil-oss/kyverno that referenced this pull request Dec 29, 2022
* refactor: registry client

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* fix

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* fix

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* fix

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* fix

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Signed-off-by: Md Sahil <Mohdssahil1@gmail.com>
MdSahil-oss pushed a commit to MdSahil-oss/kyverno that referenced this pull request Jan 11, 2023
* refactor: registry client

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* fix

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* fix

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* fix

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* fix

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
MdSahil-oss pushed a commit to MdSahil-oss/kyverno that referenced this pull request Jan 11, 2023
* refactor: registry client

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* fix

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* fix

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* fix

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* fix

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants