Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use lister for CA secret #5598

Merged
merged 2 commits into from
Dec 7, 2022
Merged

fix: use lister for CA secret #5598

merged 2 commits into from
Dec 7, 2022

Conversation

eddycharly
Copy link
Member

Explanation

This PR uses a lister for CA secret instead of making api calls.

@eddycharly
fix: use lister for CA secret
fed980b 
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
@eddycharly eddycharly added this to the Kyverno Release 1.9.0 milestone Dec 6, 2022
@eddycharly eddycharly mentioned this pull request Dec 6, 2022
Closed
2 tasks
@codecov
Copy link

codecov bot commented Dec 6, 2022 •
edited

Codecov Report

Merging #5598 (fed980b) into main (a386844) will not change coverage.
The diff coverage is 0.00%.

❗ Current head fed980b differs from pull request most recent head fc8e776. Consider uploading reports for the commit fc8e776 to get more accurate results

@@           Coverage Diff           @@
##             main    #5598   +/-   ##
=======================================
  Coverage   36.51%   36.51%           
=======================================
  Files         173      173           
  Lines       19240    19240           
=======================================
  Hits         7025     7025           
  Misses      11425    11425           
  Partials      790      790
Impacted Files Coverage Δ
pkg/controllers/webhook/controller.go 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

realshuting
realshuting approved these changes Dec 7, 2022
View reviewed changes
Copy link
Member

@realshuting realshuting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Good work Charles!

@realshuting realshuting merged commit c8185fe into kyverno:main Dec 7, 2022
@eddycharly eddycharly deleted the fix-secret-client branch December 7, 2022 09:36
MdSahil-oss pushed a commit to MdSahil-oss/kyverno that referenced this pull request Dec 29, 2022
@eddycharly @MdSahil-oss
fix: use lister for CA secret (kyverno#5598)
1e36ddf 
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Signed-off-by: Md Sahil <Mohdssahil1@gmail.com>
MdSahil-oss pushed a commit to MdSahil-oss/kyverno that referenced this pull request Jan 11, 2023
@eddycharly @MdSahil-oss
fix: use lister for CA secret (kyverno#5598)
2598105 
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
MdSahil-oss pushed a commit to MdSahil-oss/kyverno that referenced this pull request Jan 11, 2023
@eddycharly @MdSahil-oss
fix: use lister for CA secret (kyverno#5598)
15343e5 
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@realshuting realshuting realshuting approved these changes

@JimBugwadia JimBugwadia Awaiting requested review from JimBugwadia

Assignees
No one assigned
Labels
milestone 1.9.0
Projects
None yet
Milestone
Kyverno Release 1.9.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eddycharly @realshuting