feat: implement cleanup policy matching #5614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
eddycharly
requested review from
treydock,
prateekpandey14 and
chipzoller
as code owners
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
realshuting
reviewed
Dec 7, 2022
| if resourceName == "" { | ||
| resourceName = resource.GetGenerateName() | ||
| } | ||
| if conditionBlock.Name != "" { |
There was a problem hiding this comment.
I remember name is deprecated and will be replaced by names, but I don't find the deprecation label on this field.
| } | ||
| } | ||
| } | ||
| // keys := append(admissionInfo.AdmissionUserInfo.Groups, admissionInfo.AdmissionUserInfo.Username) |
There was a problem hiding this comment.
Not sure why commenting out userInfo related logic. If we don't have it supported in this PR, would be good to remove them.
There was a problem hiding this comment.
We just can't support admission related criterias at this point.
realshuting
previously approved these changes
Dec 8, 2022
Codecov Report
@@ Coverage Diff @@
## main #5614 +/- ##
==========================================
- Coverage 36.47% 36.38% -0.10%
==========================================
Files 174 174
Lines 19254 19157 -97
==========================================
- Hits 7023 6970 -53
+ Misses 11440 11407 -33
+ Partials 791 780 -11
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
realshuting
approved these changes
Dec 8, 2022
MdSahil-oss
pushed a commit
to MdSahil-oss/kyverno
that referenced
this pull request
Dec 29, 2022
* chore: bump a couple of deps Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> * feat: implement cleanup policy matching Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> * fix Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> * delete Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> * check namespace Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> * ns labels Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> * review Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> * fix tests Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> Signed-off-by: Md Sahil <Mohdssahil1@gmail.com>
MdSahil-oss
pushed a commit
to MdSahil-oss/kyverno
that referenced
this pull request
Jan 11, 2023
* chore: bump a couple of deps Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> * feat: implement cleanup policy matching Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> * fix Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> * delete Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> * check namespace Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> * ns labels Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> * review Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> * fix tests Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
MdSahil-oss
pushed a commit
to MdSahil-oss/kyverno
that referenced
this pull request
Jan 11, 2023
* chore: bump a couple of deps Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> * feat: implement cleanup policy matching Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> * fix Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> * delete Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> * check namespace Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> * ns labels Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> * review Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> * fix tests Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR implements cleanup policy matching against resources