feat: use lister in registry client #5620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Codecov Report
@@ Coverage Diff @@
## main #5620 +/- ##
=======================================
Coverage 36.38% 36.38%
=======================================
Files 174 174
Lines 19157 19152 -5
=======================================
- Hits 6970 6969 -1
+ Misses 11407 11404 -3
+ Partials 780 779 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
realshuting
reviewed
Dec 8, 2022
| @@ -92,7 +88,7 @@ func WithKeychainPullSecrets(ctx context.Context, kubClient kubernetes.Interface | |||
| ) | |||
| return nil | |||
| } | |||
| return c.pullSecretRefresher(ctx, c) | |||
| return nil | |||
There was a problem hiding this comment.
Return nil? We don't execute it?
There was a problem hiding this comment.
Nope, we run it lazily when a call has to be made.
The caller does not need to refresh anymore.
realshuting
approved these changes
Dec 8, 2022
MdSahil-oss
pushed a commit
to MdSahil-oss/kyverno
that referenced
this pull request
Dec 29, 2022
Signed-off-by: Md Sahil <Mohdssahil1@gmail.com>
MdSahil-oss
pushed a commit
to MdSahil-oss/kyverno
that referenced
this pull request
Jan 11, 2023
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
MdSahil-oss
pushed a commit
to MdSahil-oss/kyverno
that referenced
this pull request
Jan 11, 2023
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR uses a lister in registry client to fetch image pull secrets instead of making api calls.