-
Notifications
You must be signed in to change notification settings - Fork 776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: registry client not propagated correctly #5622
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Codecov Report
@@ Coverage Diff @@
## main #5622 +/- ##
=======================================
Coverage 36.38% 36.39%
=======================================
Files 174 174
Lines 19157 19159 +2
=======================================
+ Hits 6970 6972 +2
Misses 11407 11407
Partials 780 780
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
realshuting
reviewed
Dec 8, 2022
@@ -36,7 +36,7 @@ func LoadContext(logger logr.Logger, rclient registryclient.Client, contextEntri | |||
// Context Variable should be loaded after the values loaded from values file | |||
for _, entry := range contextEntries { | |||
if entry.ImageRegistry != nil && hasRegistryAccess { | |||
// rclient := store.GetRegistryClient() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Must have missed it :(
realshuting
approved these changes
Dec 8, 2022
MdSahil-oss
pushed a commit
to MdSahil-oss/kyverno
that referenced
this pull request
Dec 29, 2022
* fix: registry client not propagated correctly Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> * fix Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> Signed-off-by: Md Sahil <Mohdssahil1@gmail.com>
MdSahil-oss
pushed a commit
to MdSahil-oss/kyverno
that referenced
this pull request
Jan 11, 2023
* fix: registry client not propagated correctly Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> * fix Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
MdSahil-oss
pushed a commit
to MdSahil-oss/kyverno
that referenced
this pull request
Jan 11, 2023
* fix: registry client not propagated correctly Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> * fix Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR fixes the registry client not propagated correctly.