Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve cleanup policies controller and chart #5628

Merged
merged 7 commits into from
Dec 9, 2022

Conversation

eddycharly
Copy link
Member

Explanation

This PR improves cleanup policies controller and helm chart:

  • adds metrics
  • adds tracing
  • adds dump payload
  • adds most of the missing values in helm chart
  • adds pdb

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Merging #5628 (75629db) into main (99d988e) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #5628      +/-   ##
==========================================
- Coverage   36.14%   36.07%   -0.07%     
==========================================
  Files         177      177              
  Lines       19813    19850      +37     
==========================================
  Hits         7161     7161              
- Misses      11859    11896      +37     
  Partials      793      793              
Impacted Files Coverage Δ
pkg/webhooks/handlers/metrics.go 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Charles-Edouard Brétéché <charled.breteche@gmail.com>
@eddycharly eddycharly enabled auto-merge (squash) December 9, 2022 16:40
@eddycharly eddycharly merged commit d16bdba into kyverno:main Dec 9, 2022
MdSahil-oss pushed a commit to MdSahil-oss/kyverno that referenced this pull request Dec 29, 2022
* feat: improve cleanup policies controller

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* helm improvements

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* todo

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Signed-off-by: Charles-Edouard Brétéché <charled.breteche@gmail.com>
Signed-off-by: Md Sahil <Mohdssahil1@gmail.com>
MdSahil-oss pushed a commit to MdSahil-oss/kyverno that referenced this pull request Jan 11, 2023
* feat: improve cleanup policies controller

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* helm improvements

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* todo

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Signed-off-by: Charles-Edouard Brétéché <charled.breteche@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
MdSahil-oss pushed a commit to MdSahil-oss/kyverno that referenced this pull request Jan 11, 2023
* feat: improve cleanup policies controller

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* helm improvements

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* todo

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Signed-off-by: Charles-Edouard Brétéché <charled.breteche@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants