fix mutation patch bytes #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…are verified in the first iteration
|
As issue #562 requires more analysis, should the above fixes be on hold and merged after the solution is completely fixed ? or this does contain some critical fixes for a mutation that needs to be merged ASAP? |
|
This is not the fix for #562, it's a fix when generating mutation patch bytes, which removes condition checks in the second iteration, as it's handled in the first scan. |
shivdudhani
approved these changes
Dec 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the mutation, there are 2 iterations, the first would check the matched conditions, and only if they match, we will generate patch bytes in the second iteration.
This PR removes condition check while generating mutation patch, as conditions are already verified in the first iteration.