Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: propagate context through engine #5639

Merged
merged 6 commits into from
Dec 9, 2022
Merged

feat: propagate context through engine #5639

merged 6 commits into from
Dec 9, 2022

Conversation

eddycharly
Copy link
Member

Explanation

This PR propagates context through engine code.
This is need for proper tracing.

@eddycharly
feat: propagate context through engine
35cf218 
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
@eddycharly eddycharly added this to the Kyverno Release 1.9.0 milestone Dec 9, 2022
@codecov
Copy link

codecov bot commented Dec 9, 2022 •
edited

Codecov Report

Merging #5639 (db8da32) into main (5079790) will decrease coverage by 0.00%.
The diff coverage is 46.59%.

@@            Coverage Diff             @@
##             main    #5639      +/-   ##
==========================================
- Coverage   35.87%   35.87%   -0.01%     
==========================================
  Files         176      176              
  Lines       19458    19459       +1     
==========================================
  Hits         6981     6981              
- Misses      11694    11695       +1     
  Partials      783      783
Impacted Files Coverage Δ
pkg/background/generate/generate.go 0.00% <0.00%> (ø)
pkg/engine/background.go 0.00% <0.00%> (ø)
pkg/engine/imageVerifyValidate.go 11.25% <0.00%> (ø)
pkg/policy/apply.go 0.00% <0.00%> (ø)
pkg/webhooks/resource/generation/generation.go 0.00% <0.00%> (ø)
pkg/webhooks/resource/generation/utils.go 39.28% <0.00%> (ø)
pkg/webhooks/resource/utils.go 35.18% <0.00%> (ø)
pkg/engine/jsonContext.go 12.28% <24.32%> (ø)
pkg/cosign/cosign.go 29.13% <54.54%> (ø)
pkg/engine/validation.go 62.50% <68.42%> (ø)
... and 6 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@eddycharly
feat: propagate context through engine
ba1da18 
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
@eddycharly
feat: propagate context through engine
36cdac4 
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
@eddycharly eddycharly marked this pull request as ready for review December 9, 2022 11:04
eddycharly and others added 2 commits December 9, 2022 12:19
@eddycharly
feat: propagate context through engine
9c08fbd 
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
@eddycharly
Merge branch 'main' into engine-context
db8da32
realshuting
realshuting approved these changes Dec 9, 2022
View reviewed changes
Copy link
Member

@realshuting realshuting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems straightforward enough, lgtm.

@realshuting realshuting merged commit ff728d5 into kyverno:main Dec 9, 2022
@realshuting realshuting mentioned this pull request Dec 12, 2022
Merged
9 tasks
MdSahil-oss pushed a commit to MdSahil-oss/kyverno that referenced this pull request Dec 29, 2022
@eddycharly @MdSahil-oss
feat: propagate context through engine (kyverno#5639)
d4a5682 
* feat: propagate context through engine

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* feat: propagate context through engine

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* feat: propagate context through engine

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* feat: propagate context through engine

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Signed-off-by: Md Sahil <Mohdssahil1@gmail.com>
MdSahil-oss pushed a commit to MdSahil-oss/kyverno that referenced this pull request Jan 11, 2023
@eddycharly @MdSahil-oss
feat: propagate context through engine (kyverno#5639)
592c4fd 
* feat: propagate context through engine

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* feat: propagate context through engine

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* feat: propagate context through engine

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* feat: propagate context through engine

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
MdSahil-oss pushed a commit to MdSahil-oss/kyverno that referenced this pull request Jan 11, 2023
@eddycharly @MdSahil-oss
feat: propagate context through engine (kyverno#5639)
5542c2f 
* feat: propagate context through engine

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* feat: propagate context through engine

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* feat: propagate context through engine

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* feat: propagate context through engine

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@realshuting realshuting realshuting approved these changes

@prateekpandey14 prateekpandey14 Awaiting requested review from prateekpandey14

Assignees
No one assigned
Labels
milestone 1.9.0
Projects
None yet
Milestone
Kyverno Release 1.9.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eddycharly @realshuting