Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add metrics service and service monitor to cleanup controller #5653

Merged
merged 11 commits into from
Dec 12, 2022

Conversation

eddycharly
Copy link
Member

Signed-off-by: Charles-Edouard Brétéché charles.edouard@nirmata.com

Explanation

This PR adds metrics service and service monitor to cleanup controller.

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
@codecov
Copy link

codecov bot commented Dec 12, 2022

Codecov Report

Merging #5653 (634e9e6) into main (4600340) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #5653   +/-   ##
=======================================
  Coverage   36.13%   36.13%           
=======================================
  Files         178      178           
  Lines       19900    19900           
=======================================
  Hits         7191     7191           
  Misses      11916    11916           
  Partials      793      793           
Impacted Files Coverage Δ
...d/cleanup-controller/handlers/cleanup/condition.go 17.85% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

eddycharly and others added 3 commits December 12, 2022 10:35
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
@eddycharly eddycharly marked this pull request as ready for review December 12, 2022 10:10
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
eddycharly and others added 4 commits December 12, 2022 14:18
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
@eddycharly eddycharly enabled auto-merge (squash) December 12, 2022 18:05
@eddycharly eddycharly merged commit f927b51 into kyverno:main Dec 12, 2022
MdSahil-oss pushed a commit to MdSahil-oss/kyverno that referenced this pull request Dec 29, 2022
…yverno#5653)

* feat: add metrics service and service monitor to cleanup controller

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* more config

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* name and certs

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* fix: conditions check

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* leader election

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* workflows

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* rbac

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Co-authored-by: Jim Bugwadia <jim@nirmata.com>
Signed-off-by: Md Sahil <Mohdssahil1@gmail.com>
MdSahil-oss pushed a commit to MdSahil-oss/kyverno that referenced this pull request Jan 11, 2023
…yverno#5653)

* feat: add metrics service and service monitor to cleanup controller

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* more config

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* name and certs

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* fix: conditions check

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* leader election

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* workflows

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* rbac

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Co-authored-by: Jim Bugwadia <jim@nirmata.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
MdSahil-oss pushed a commit to MdSahil-oss/kyverno that referenced this pull request Jan 11, 2023
…yverno#5653)

* feat: add metrics service and service monitor to cleanup controller

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* more config

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* name and certs

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* fix: conditions check

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* leader election

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* workflows

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* rbac

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Co-authored-by: Jim Bugwadia <jim@nirmata.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants