-
Notifications
You must be signed in to change notification settings - Fork 776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use camel case for ForEach naming #5660
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jim Bugwadia <jim@nirmata.com>
JimBugwadia
requested review from
eddycharly and
prateekpandey14
as code owners
December 12, 2022 18:11
Signed-off-by: Jim Bugwadia <jim@nirmata.com>
eddycharly
previously approved these changes
Dec 12, 2022
@JimBugwadia does this require some changes in my tracing PR ? |
No, I missed some changes. Updated the PR. Please re-review! |
eddycharly
approved these changes
Dec 12, 2022
Codecov Report
@@ Coverage Diff @@
## main #5660 +/- ##
=======================================
Coverage 36.13% 36.13%
=======================================
Files 178 178
Lines 19900 19900
=======================================
Hits 7191 7191
Misses 11916 11916
Partials 793 793
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
MdSahil-oss
pushed a commit
to MdSahil-oss/kyverno
that referenced
this pull request
Dec 29, 2022
Signed-off-by: Jim Bugwadia <jim@nirmata.com> Signed-off-by: Jim Bugwadia <jim@nirmata.com> Signed-off-by: Md Sahil <Mohdssahil1@gmail.com>
MdSahil-oss
pushed a commit
to MdSahil-oss/kyverno
that referenced
this pull request
Jan 11, 2023
Signed-off-by: Jim Bugwadia <jim@nirmata.com> Signed-off-by: Jim Bugwadia <jim@nirmata.com> Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
MdSahil-oss
pushed a commit
to MdSahil-oss/kyverno
that referenced
this pull request
Jan 11, 2023
Signed-off-by: Jim Bugwadia <jim@nirmata.com> Signed-off-by: Jim Bugwadia <jim@nirmata.com> Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jim Bugwadia jim@nirmata.com
Explanation
update ForEach method and var names
Related issue
n/a
Milestone of this PR
What type of PR is this
/kind cleanup
Proposed Changes
Proof Manifests
Checklist
Further Comments