Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use camel case for ForEach naming #5660

Merged
merged 4 commits into from
Dec 12, 2022

Conversation

JimBugwadia
Copy link
Member

@JimBugwadia JimBugwadia commented Dec 12, 2022

Signed-off-by: Jim Bugwadia jim@nirmata.com

Explanation

update ForEach method and var names

Related issue

n/a

Milestone of this PR

What type of PR is this

/kind cleanup

Proposed Changes

Proof Manifests

Checklist

  • I have read the contributing guidelines.
  • I have read the PR documentation guide and followed the process including adding proof manifests to this PR.
  • This is a bug fix and I have added unit tests that prove my fix is effective.
  • This is a feature and I have added CLI tests that are applicable.
  • My PR needs to be cherry picked to a specific release branch which is .
  • My PR contains new or altered behavior to Kyverno and
    • CLI support should be added and my PR doesn't contain that functionality.
    • I have added or changed the documentation myself in an existing PR and the link is:
    • I have raised an issue in kyverno/website to track the documentation update and the link is:

Further Comments

Signed-off-by: Jim Bugwadia <jim@nirmata.com>
eddycharly
eddycharly previously approved these changes Dec 12, 2022
@eddycharly
Copy link
Member

@JimBugwadia does this require some changes in my tracing PR ?

@JimBugwadia
Copy link
Member Author

@JimBugwadia does this require some changes in my tracing PR ?

No, I missed some changes. Updated the PR. Please re-review!

@codecov
Copy link

codecov bot commented Dec 12, 2022

Codecov Report

Merging #5660 (674d56f) into main (4600340) will not change coverage.
The diff coverage is 60.86%.

@@           Coverage Diff           @@
##             main    #5660   +/-   ##
=======================================
  Coverage   36.13%   36.13%           
=======================================
  Files         178      178           
  Lines       19900    19900           
=======================================
  Hits         7191     7191           
  Misses      11916    11916           
  Partials      793      793           
Impacted Files Coverage Δ
...d/cleanup-controller/handlers/cleanup/condition.go 17.85% <0.00%> (ø)
cmd/cli/kubectl-kyverno/utils/common/common.go 17.55% <0.00%> (ø)
pkg/engine/forceMutate.go 35.08% <0.00%> (ø)
pkg/engine/jsonContext.go 12.28% <0.00%> (ø)
pkg/engine/validation.go 64.23% <88.88%> (ø)
pkg/autogen/rule.go 76.47% <100.00%> (ø)
pkg/engine/mutation.go 64.36% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@JimBugwadia JimBugwadia merged commit af4c8ed into kyverno:main Dec 12, 2022
@eddycharly eddycharly added this to the Kyverno Release 1.9.0 milestone Dec 13, 2022
MdSahil-oss pushed a commit to MdSahil-oss/kyverno that referenced this pull request Dec 29, 2022
Signed-off-by: Jim Bugwadia <jim@nirmata.com>

Signed-off-by: Jim Bugwadia <jim@nirmata.com>
Signed-off-by: Md Sahil <Mohdssahil1@gmail.com>
@JimBugwadia JimBugwadia deleted the forEachCamelCase branch January 11, 2023 00:37
MdSahil-oss pushed a commit to MdSahil-oss/kyverno that referenced this pull request Jan 11, 2023
Signed-off-by: Jim Bugwadia <jim@nirmata.com>

Signed-off-by: Jim Bugwadia <jim@nirmata.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
MdSahil-oss pushed a commit to MdSahil-oss/kyverno that referenced this pull request Jan 11, 2023
Signed-off-by: Jim Bugwadia <jim@nirmata.com>

Signed-off-by: Jim Bugwadia <jim@nirmata.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants