feat: add policy exception validation webhook #5679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
eddycharly
requested review from
treydock,
prateekpandey14 and
chipzoller
as code owners
Codecov Report
@@ Coverage Diff @@
## main #5679 +/- ##
==========================================
- Coverage 34.48% 34.41% -0.07%
==========================================
Files 189 191 +2
Lines 21113 21151 +38
==========================================
Hits 7280 7280
- Misses 13032 13070 +38
Partials 801 801
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
9 tasks
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
20 tasks
JimBugwadia
approved these changes
Dec 14, 2022
| // errs = append(errs, p.ExcludeResources.Validate(path.Child("exclude"), namespaced, clusterResources)...) | ||
| // } | ||
| // errs = append(errs, p.ValidateMatchExcludeConflict(path)...) | ||
| return errs |
There was a problem hiding this comment.
please remove commented lines
| admissionv1 "k8s.io/api/admission/v1" | ||
| ) | ||
|
|
||
| // TODO: wrap this into an interface passed at server creation time |
There was a problem hiding this comment.
Yes, we don’t want the server to directly call the implementation, it should go through an interface.
JimBugwadia
approved these changes
Dec 14, 2022
MdSahil-oss
pushed a commit
to MdSahil-oss/kyverno
that referenced
this pull request
Dec 29, 2022
* feat: add policy exception validation webhook Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> * fix Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> * handler Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> * validation Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> Co-authored-by: Jim Bugwadia <jim@nirmata.com> Signed-off-by: Md Sahil <Mohdssahil1@gmail.com>
MdSahil-oss
pushed a commit
to MdSahil-oss/kyverno
that referenced
this pull request
Jan 11, 2023
* feat: add policy exception validation webhook Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> * fix Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> * handler Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> * validation Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> Co-authored-by: Jim Bugwadia <jim@nirmata.com> Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
MdSahil-oss
pushed a commit
to MdSahil-oss/kyverno
that referenced
this pull request
Jan 11, 2023
* feat: add policy exception validation webhook Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> * fix Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> * handler Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> * validation Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> Co-authored-by: Jim Bugwadia <jim@nirmata.com> Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Charles-Edouard Brétéché charles.edouard@nirmata.com
Explanation
This PR adds a policy exception validation webhook.