fix info kind error #5701
Merged
fix info kind error #5701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddycharly
reviewed
Dec 15, 2022
|
TBH I prefer gvk/gvr to be objects. |
If so, is it necessary to unify? Not change here, but change other places? Now they are not unified. |
Codecov Report
@@ Coverage Diff @@
## main #5701 +/- ##
==========================================
- Coverage 34.42% 34.42% -0.01%
==========================================
Files 191 191
Lines 21145 21146 +1
==========================================
Hits 7280 7280
- Misses 13064 13065 +1
Partials 801 801
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
For kind I suppose it should be only the kind, for gvr/gvk it makes sense to keep it as an object, it will allow more fine-grained queries. |
Signed-off-by: cleverhu <shouping.hu@daocloud.io>
cleverhu
force-pushed
the
fix-info-kind-error
branch
from
f8ead64
to
cddb6bb
Compare
I unified it in |
MdSahil-oss
pushed a commit
to MdSahil-oss/kyverno
that referenced
this pull request
Dec 29, 2022
Signed-off-by: cleverhu <shouping.hu@daocloud.io> Signed-off-by: cleverhu <shouping.hu@daocloud.io> Signed-off-by: Md Sahil <Mohdssahil1@gmail.com>
MdSahil-oss
pushed a commit
to MdSahil-oss/kyverno
that referenced
this pull request
Jan 11, 2023
Signed-off-by: cleverhu <shouping.hu@daocloud.io> Signed-off-by: cleverhu <shouping.hu@daocloud.io> Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
MdSahil-oss
pushed a commit
to MdSahil-oss/kyverno
that referenced
this pull request
Jan 11, 2023
Signed-off-by: cleverhu <shouping.hu@daocloud.io> Signed-off-by: cleverhu <shouping.hu@daocloud.io> Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Unify the format of gvk, gvr, kind. Fix info kind msg.
Related issue
#5641
Milestone of this PR
What type of PR is this
/kind bug
Proposed Changes
Proof Manifests
Checklist
Further Comments