refactor: move util funcs in sub packages #5754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
eddycharly
requested review from
prateekpandey14 and
vyankyGH
as code owners
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Codecov Report
@@ Coverage Diff @@
## main #5754 +/- ##
=======================================
Coverage ? 34.88%
=======================================
Files ? 189
Lines ? 20862
Branches ? 0
=======================================
Hits ? 7277
Misses ? 12782
Partials ? 803
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
realshuting
reviewed
Dec 22, 2022
| @@ -53,7 +53,7 @@ func main() { | |||
| kyvernoClient := internal.CreateKyvernoClient(logger) | |||
| client := internal.CreateDClient(logger, ctx, dynamicClient, kubeClient, 15*time.Minute) | |||
| // Exit for unsupported version of kubernetes cluster | |||
| if !utils.HigherThanKubernetesVersion(kubeClient.Discovery(), logging.GlobalLogger(), 1, 16, 0) { | |||
| if !kubeutils.HigherThanKubernetesVersion(kubeClient.Discovery(), logging.GlobalLogger(), 1, 16, 0) { | |||
There was a problem hiding this comment.
This check is no longer needed, we should consider removing it.
Signed-off-by: shuting <shutting06@gmail.com>
realshuting
approved these changes
Dec 22, 2022
MdSahil-oss
pushed a commit
to MdSahil-oss/kyverno
that referenced
this pull request
Dec 29, 2022
* refactor: move util func in sub packages Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> * fix Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> * Update pkg/utils/kube/crd.go Signed-off-by: shuting <shutting06@gmail.com> Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> Signed-off-by: shuting <shutting06@gmail.com> Co-authored-by: shuting <shutting06@gmail.com> Signed-off-by: Md Sahil <Mohdssahil1@gmail.com>
MdSahil-oss
pushed a commit
to MdSahil-oss/kyverno
that referenced
this pull request
Jan 11, 2023
* refactor: move util func in sub packages Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> * fix Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> * Update pkg/utils/kube/crd.go Signed-off-by: shuting <shutting06@gmail.com> Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> Signed-off-by: shuting <shutting06@gmail.com> Co-authored-by: shuting <shutting06@gmail.com> Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
MdSahil-oss
pushed a commit
to MdSahil-oss/kyverno
that referenced
this pull request
Jan 11, 2023
* refactor: move util func in sub packages Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> * fix Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> * Update pkg/utils/kube/crd.go Signed-off-by: shuting <shutting06@gmail.com> Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> Signed-off-by: shuting <shutting06@gmail.com> Co-authored-by: shuting <shutting06@gmail.com> Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR moves a couple util funcs in sub packages.
The root utils package is too generic and it will be easier to track unit tests coverage.