Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix delete policy #5776

Merged
merged 2 commits into from
Dec 27, 2022
Merged

fix delete policy #5776

merged 2 commits into from
Dec 27, 2022

Conversation

cleverhu
Copy link
Contributor

@cleverhu cleverhu commented Dec 23, 2022

Explanation

Fix remove generated resource upon Policy deletion bug when delete policy.

Related issue

Fixes #5753

Milestone of this PR

What type of PR is this

/kind bug

Proposed Changes

Proof Manifests

Checklist

  • I have read the contributing guidelines.
  • I have read the PR documentation guide and followed the process including adding proof manifests to this PR.
  • This is a bug fix and I have added unit tests that prove my fix is effective.
  • This is a feature and I have added CLI tests that are applicable.
  • My PR needs to be cherry picked to a specific release branch which is .
  • My PR contains new or altered behavior to Kyverno and
    • CLI support should be added and my PR doesn't contain that functionality.
    • I have added or changed the documentation myself in an existing PR and the link is:
    • I have raised an issue in kyverno/website to track the documentation update and the link is:

Further Comments

Signed-off-by: cleverhu <shouping.hu@daocloud.io>
@codecov
Copy link

codecov bot commented Dec 23, 2022

Codecov Report

Merging #5776 (f09d498) into main (787a1dc) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #5776   +/-   ##
=======================================
  Coverage   34.91%   34.91%           
=======================================
  Files         190      190           
  Lines       21026    21026           
=======================================
  Hits         7342     7342           
  Misses      12869    12869           
  Partials      815      815           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cleverhu
Copy link
Contributor Author

/kind bug

Copy link
Member

@realshuting realshuting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks for the fix @cleverhu !

@realshuting
Copy link
Member

I'm adding this to 1.9.0, @chipzoller - what do you think?

@chipzoller
Copy link
Member

Sounds good to me. We need all the generate fixes we can get.

@realshuting
Copy link
Member

ok.

/cherry-pick release-1.9

@realshuting realshuting merged commit e9ea3ea into kyverno:main Dec 27, 2022
realshuting pushed a commit to realshuting/kyverno that referenced this pull request Dec 27, 2022
Signed-off-by: cleverhu <shouping.hu@daocloud.io>

Signed-off-by: cleverhu <shouping.hu@daocloud.io>
Signed-off-by: ShutingZhao <shuting@nirmata.com>
@realshuting realshuting added the cherry-pick-completed The PR was cherry-picked (or merged) to required release branches label Dec 27, 2022
realshuting added a commit that referenced this pull request Dec 27, 2022
Signed-off-by: cleverhu <shouping.hu@daocloud.io>

Signed-off-by: cleverhu <shouping.hu@daocloud.io>
Signed-off-by: ShutingZhao <shuting@nirmata.com>

Signed-off-by: cleverhu <shouping.hu@daocloud.io>
Signed-off-by: ShutingZhao <shuting@nirmata.com>
Co-authored-by: cleverhu <shouping.hu@daocloud.io>
MdSahil-oss pushed a commit to MdSahil-oss/kyverno that referenced this pull request Dec 29, 2022
Signed-off-by: cleverhu <shouping.hu@daocloud.io>

Signed-off-by: cleverhu <shouping.hu@daocloud.io>
Signed-off-by: Md Sahil <Mohdssahil1@gmail.com>
MdSahil-oss pushed a commit to MdSahil-oss/kyverno that referenced this pull request Jan 11, 2023
Signed-off-by: cleverhu <shouping.hu@daocloud.io>

Signed-off-by: cleverhu <shouping.hu@daocloud.io>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
MdSahil-oss pushed a commit to MdSahil-oss/kyverno that referenced this pull request Jan 11, 2023
Signed-off-by: cleverhu <shouping.hu@daocloud.io>

Signed-off-by: cleverhu <shouping.hu@daocloud.io>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-completed The PR was cherry-picked (or merged) to required release branches cherry-pick-required milestone 1.9.0
Projects
None yet
3 participants