-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix delete policy #5776
fix delete policy #5776
Conversation
Signed-off-by: cleverhu <shouping.hu@daocloud.io>
Codecov Report
@@ Coverage Diff @@
## main #5776 +/- ##
=======================================
Coverage 34.91% 34.91%
=======================================
Files 190 190
Lines 21026 21026
=======================================
Hits 7342 7342
Misses 12869 12869
Partials 815 815 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
/kind bug |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks for the fix @cleverhu !
I'm adding this to 1.9.0, @chipzoller - what do you think? |
Sounds good to me. We need all the generate fixes we can get. |
ok. /cherry-pick release-1.9 |
Signed-off-by: cleverhu <shouping.hu@daocloud.io> Signed-off-by: cleverhu <shouping.hu@daocloud.io> Signed-off-by: ShutingZhao <shuting@nirmata.com>
Signed-off-by: cleverhu <shouping.hu@daocloud.io> Signed-off-by: cleverhu <shouping.hu@daocloud.io> Signed-off-by: ShutingZhao <shuting@nirmata.com> Signed-off-by: cleverhu <shouping.hu@daocloud.io> Signed-off-by: ShutingZhao <shuting@nirmata.com> Co-authored-by: cleverhu <shouping.hu@daocloud.io>
Signed-off-by: cleverhu <shouping.hu@daocloud.io> Signed-off-by: cleverhu <shouping.hu@daocloud.io> Signed-off-by: Md Sahil <Mohdssahil1@gmail.com>
Signed-off-by: cleverhu <shouping.hu@daocloud.io> Signed-off-by: cleverhu <shouping.hu@daocloud.io> Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: cleverhu <shouping.hu@daocloud.io> Signed-off-by: cleverhu <shouping.hu@daocloud.io> Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Explanation
Fix remove generated resource upon Policy deletion bug when delete policy.
Related issue
Fixes #5753
Milestone of this PR
What type of PR is this
/kind bug
Proposed Changes
Proof Manifests
Checklist
Further Comments