Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix cli output adjustments #5787

Merged
merged 9 commits into from
Dec 27, 2022
Merged

fix cli output adjustments #5787

merged 9 commits into from
Dec 27, 2022

Conversation

cleverhu
Copy link
Contributor

@cleverhu cleverhu commented Dec 27, 2022 •
edited by chipzoller

Explanation

optimize cli output adjustments

Related issue

Closes #5786

Milestone of this PR

What type of PR is this

/kind bug

Proposed Changes

Proof Manifests

Checklist

  • I have read the contributing guidelines.
  • I have read the PR documentation guide and followed the process including adding proof manifests to this PR.
  • This is a bug fix and I have added unit tests that prove my fix is effective.
  • This is a feature and I have added CLI tests that are applicable.
  • My PR needs to be cherry picked to a specific release branch which is .
  • My PR contains new or altered behavior to Kyverno and
    • CLI support should be added and my PR doesn't contain that functionality.
    • I have added or changed the documentation myself in an existing PR and the link is:
    • I have raised an issue in kyverno/website to track the documentation update and the link is:

Further Comments

fix cli output adjustments
218200e 
Signed-off-by: cleverhu <shouping.hu@daocloud.io>
@cleverhu
Copy link
Contributor Author

This is the output after optimize:
image

@codecov
Copy link

codecov bot commented Dec 27, 2022 •
edited

Codecov Report

Merging #5787 (affc8b3) into main (c3ab068) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #5787   +/-   ##
=======================================
  Coverage   34.91%   34.91%           
=======================================
  Files         190      190           
  Lines       21026    21026           
=======================================
  Hits         7342     7342           
  Misses      12869    12869           
  Partials      815      815
Impacted Files Coverage Δ
cmd/cli/kubectl-kyverno/apply/apply_command.go 24.47% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

realshuting
realshuting previously approved these changes Dec 27, 2022
View reviewed changes
@realshuting realshuting enabled auto-merge (squash) December 27, 2022 12:39
@realshuting
Copy link
Member

/cherry-pick release-1.9

@realshuting realshuting self-assigned this Dec 27, 2022
@chipzoller
Copy link
Member

Thanks, @cleverhu! Please note the periods I also added.

realshuting
realshuting reviewed Dec 27, 2022
View reviewed changes
cmd/cli/kubectl-kyverno/jp/jp.go Outdated Show resolved Hide resolved
cmd/cli/kubectl-kyverno/test/test_command.go Outdated Show resolved Hide resolved
cmd/cli/kubectl-kyverno/apply/apply_command.go Outdated Show resolved Hide resolved
@realshuting
Update cmd/cli/kubectl-kyverno/jp/jp.go
c70c8d4 
Signed-off-by: shuting <shutting06@gmail.com>
@realshuting
Update cmd/cli/kubectl-kyverno/apply/apply_command.go
6f6f641 
Signed-off-by: shuting <shutting06@gmail.com>
@realshuting
Update cmd/cli/kubectl-kyverno/test/test_command.go
13a4c2f 
Signed-off-by: shuting <shutting06@gmail.com>
realshuting and others added 2 commits December 27, 2022 21:32
@realshuting
Update cmd/cli/kubectl-kyverno/jp/jp.go
19b60bf 
Signed-off-by: shuting <shutting06@gmail.com>
@realshuting
update commands' help message
3441e82 
Signed-off-by: ShutingZhao <shuting@nirmata.com>
@realshuting
Copy link
Member

realshuting commented Dec 27, 2022 •
edited

Thanks, @cleverhu! Please note the periods I also added.

@chipzoller - I've added periods to all commands.

But I don't see completion, is this a Kyverno command?

#5786 (comment):

The command of help and completion can not be changed because this is a command built-in by cobra.

realshuting
realshuting previously approved these changes Dec 27, 2022
View reviewed changes
@chipzoller
Copy link
Member

I forgot about the new oci experimental command. Change to this:

oci         Pulls/pushes images which include one or more Kyverno policies from/to OCI registries.

@realshuting
update command's help message
444e06a 
Signed-off-by: ShutingZhao <shuting@nirmata.com>
@realshuting
Copy link
Member

I forgot about the new oci experimental command. Change to this:

oci         Pulls/pushes images which include one or more Kyverno policies from/to OCI registries.

Updated!

@realshuting realshuting merged commit 0edff46 into kyverno:main Dec 27, 2022
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Dec 27, 2022
fix cli output adjustments (#5787)
3776546 
Signed-off-by: cleverhu <shouping.hu@daocloud.io>

Signed-off-by: cleverhu <shouping.hu@daocloud.io>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this pull request Dec 27, 2022
Merged
@realshuting realshuting added the cherry-pick-completed The PR was cherry-picked (or merged) to required release branches label Dec 27, 2022
realshuting pushed a commit that referenced this pull request Dec 27, 2022
@gcp-cherry-pick-bot
fix cli output adjustments (#5787) (#5793)
e515bea 
Signed-off-by: cleverhu <shouping.hu@daocloud.io>

Signed-off-by: cleverhu <shouping.hu@daocloud.io>

Signed-off-by: cleverhu <shouping.hu@daocloud.io>
Co-authored-by: cleverhu <shouping.hu@daocloud.io>
MdSahil-oss pushed a commit to MdSahil-oss/kyverno that referenced this pull request Dec 29, 2022
@MdSahil-oss
fix cli output adjustments (kyverno#5787)
298a491 
Signed-off-by: cleverhu <shouping.hu@daocloud.io>

Signed-off-by: cleverhu <shouping.hu@daocloud.io>
Signed-off-by: Md Sahil <Mohdssahil1@gmail.com>
MdSahil-oss pushed a commit to MdSahil-oss/kyverno that referenced this pull request Jan 11, 2023
@MdSahil-oss
fix cli output adjustments (kyverno#5787)
a86ecea 
Signed-off-by: cleverhu <shouping.hu@daocloud.io>

Signed-off-by: cleverhu <shouping.hu@daocloud.io>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
MdSahil-oss pushed a commit to MdSahil-oss/kyverno that referenced this pull request Jan 11, 2023
@MdSahil-oss
fix cli output adjustments (kyverno#5787)
3076734 
Signed-off-by: cleverhu <shouping.hu@daocloud.io>

Signed-off-by: cleverhu <shouping.hu@daocloud.io>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@realshuting realshuting realshuting approved these changes

@chipzoller chipzoller Awaiting requested review from chipzoller

Assignees

@realshuting realshuting

Labels
cherry-pick-completed The PR was cherry-picked (or merged) to required release branches cherry-pick-required milestone 1.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] [CLI] kyverno -h output adjustments
4 participants
@cleverhu @realshuting @chipzoller @kyverno-bot