Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: background scan events #5807

Merged
merged 13 commits into from
Jan 4, 2023
Merged

Conversation

eddycharly
Copy link
Member

@eddycharly eddycharly commented Dec 29, 2022

Explanation

This PR moves background scan events from policy controller to background scan controller.

Fixes #5675

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
@codecov
Copy link

codecov bot commented Dec 29, 2022

Codecov Report

Merging #5807 (8600754) into main (744d151) will increase coverage by 0.66%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5807      +/-   ##
==========================================
+ Coverage   35.28%   35.95%   +0.66%     
==========================================
  Files         190      186       -4     
  Lines       21093    20700     -393     
==========================================
  Hits         7442     7442              
+ Misses      12834    12441     -393     
  Partials      817      817              
Impacted Files Coverage Δ
pkg/policy/policy_controller.go 5.39% <ø> (+1.24%) ⬆️
pkg/policy/utils.go 100.00% <ø> (+15.21%) ⬆️
pkg/controllers/report/utils/events.go

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

eddycharly and others added 9 commits December 29, 2022 16:01
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
@eddycharly eddycharly marked this pull request as ready for review January 3, 2023 16:13
@eddycharly
Copy link
Member Author

/cherry-pick release-1.9

@realshuting realshuting merged commit 3c0b785 into kyverno:main Jan 4, 2023
@gcp-cherry-pick-bot
Copy link

Cherry-pick failed with Merge error 3c0b7856eb3a05f5bd9f0a7369f5d6034faf783b into temp-cherry-pick-efecf8-release-1.9

@eddycharly
Copy link
Member Author

/cherry-pick release-1.9

@gcp-cherry-pick-bot
Copy link

Cherry-pick failed with Merge error 3c0b7856eb3a05f5bd9f0a7369f5d6034faf783b into temp-cherry-pick-efecf8-release-1.9

eddycharly added a commit to eddycharly/kyverno that referenced this pull request Jan 4, 2023
* fix: background scan events

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* remove old code

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* remove old code

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* fix

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* fix config

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* cleanup

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* cleanup

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* events

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
@eddycharly eddycharly added the cherry-pick-completed The PR was cherry-picked (or merged) to required release branches label Jan 4, 2023
eddycharly added a commit that referenced this pull request Jan 4, 2023
* fix: background scan events

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* remove old code

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* remove old code

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* fix

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* fix config

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* cleanup

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* cleanup

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* events

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
MdSahil-oss pushed a commit to MdSahil-oss/kyverno that referenced this pull request Jan 11, 2023
* fix: background scan events

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* remove old code

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* remove old code

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* fix

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* fix config

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* cleanup

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* cleanup

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* events

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
MdSahil-oss pushed a commit to MdSahil-oss/kyverno that referenced this pull request Jan 11, 2023
* fix: background scan events

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* remove old code

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* remove old code

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* fix

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* fix config

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* cleanup

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* cleanup

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* events

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-completed The PR was cherry-picked (or merged) to required release branches cherry-pick-required milestone 1.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Hourly spikes observed possibly related to background scanning
2 participants