-
Notifications
You must be signed in to change notification settings - Fork 776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds notes to functions #5824
Merged
Merged
Adds notes to functions #5824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vishal Choudhary <contactvishaltech@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #5824 +/- ##
==========================================
+ Coverage 35.01% 35.06% +0.05%
==========================================
Files 190 190
Lines 21027 21044 +17
==========================================
+ Hits 7362 7379 +17
Misses 12849 12849
Partials 816 816
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Vishal Choudhary <contactvishaltech@gmail.com>
eddycharly
approved these changes
Jan 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @vishal-chdhry !
/cherry-pick release-1.9 |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Jan 2, 2023
* added notes Signed-off-by: Vishal Choudhary <contactvishaltech@gmail.com> * changes stated in chart.yaml Signed-off-by: Vishal Choudhary <contactvishaltech@gmail.com> * undo Signed-off-by: Vishal Choudhary <contactvishaltech@gmail.com> Signed-off-by: Vishal Choudhary <contactvishaltech@gmail.com>
eddycharly
added
the
cherry-pick-completed
The PR was cherry-picked (or merged) to required release branches
label
Jan 2, 2023
eddycharly
pushed a commit
that referenced
this pull request
Jan 2, 2023
* added notes Signed-off-by: Vishal Choudhary <contactvishaltech@gmail.com> * changes stated in chart.yaml Signed-off-by: Vishal Choudhary <contactvishaltech@gmail.com> * undo Signed-off-by: Vishal Choudhary <contactvishaltech@gmail.com> Signed-off-by: Vishal Choudhary <contactvishaltech@gmail.com> Signed-off-by: Vishal Choudhary <contactvishaltech@gmail.com> Co-authored-by: Vishal Choudhary <contactvishaltech@gmail.com>
rgarcia89
pushed a commit
to rgarcia89/kyverno
that referenced
this pull request
Jan 2, 2023
* added notes Signed-off-by: Vishal Choudhary <contactvishaltech@gmail.com> * changes stated in chart.yaml Signed-off-by: Vishal Choudhary <contactvishaltech@gmail.com> * undo Signed-off-by: Vishal Choudhary <contactvishaltech@gmail.com> Signed-off-by: Vishal Choudhary <contactvishaltech@gmail.com> Signed-off-by: Raul Garcia Sanchez <info@raulgarcia.de>
rgarcia89
pushed a commit
to rgarcia89/kyverno
that referenced
this pull request
Jan 2, 2023
* added notes Signed-off-by: Vishal Choudhary <contactvishaltech@gmail.com> * changes stated in chart.yaml Signed-off-by: Vishal Choudhary <contactvishaltech@gmail.com> * undo Signed-off-by: Vishal Choudhary <contactvishaltech@gmail.com> Signed-off-by: Vishal Choudhary <contactvishaltech@gmail.com> Signed-off-by: Raul Garcia Sanchez <info@raulgarcia.de>
MdSahil-oss
pushed a commit
to MdSahil-oss/kyverno
that referenced
this pull request
Jan 11, 2023
* added notes Signed-off-by: Vishal Choudhary <contactvishaltech@gmail.com> * changes stated in chart.yaml Signed-off-by: Vishal Choudhary <contactvishaltech@gmail.com> * undo Signed-off-by: Vishal Choudhary <contactvishaltech@gmail.com> Signed-off-by: Vishal Choudhary <contactvishaltech@gmail.com> Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
MdSahil-oss
pushed a commit
to MdSahil-oss/kyverno
that referenced
this pull request
Jan 11, 2023
* added notes Signed-off-by: Vishal Choudhary <contactvishaltech@gmail.com> * changes stated in chart.yaml Signed-off-by: Vishal Choudhary <contactvishaltech@gmail.com> * undo Signed-off-by: Vishal Choudhary <contactvishaltech@gmail.com> Signed-off-by: Vishal Choudhary <contactvishaltech@gmail.com> Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-pick-completed
The PR was cherry-picked (or merged) to required release branches
cherry-pick-required
milestone 1.9.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vishal Choudhary contactvishaltech@gmail.com
Explanation
Adds notes to all the functions in
kyverno/pkg/engine/jmespath/functions.go
Line 120 in faeab45
Related issue
Closes #5555
Milestone of this PR
What type of PR is this
Proposed Changes
Proof Manifests
Checklist
Further Comments