Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add anchors for omitempty tag #584

Merged
merged 3 commits into from
Jan 2, 2020
Merged

Conversation

realshuting
Copy link
Member

@realshuting realshuting commented Dec 30, 2019

Fix #371.

@shivdudhani
Copy link
Contributor

The above comment fixes issue #371, but have we handled all the policies and all resource types ?
If not let's add the fixes tag for this PR

@realshuting
Copy link
Member Author

I went through policies in samples/best_practices, and tested with resource type Pod and Deployment. Since after #518, best practices would be applied to pod controllers by default.

@shivdudhani
Copy link
Contributor

shivdudhani commented Dec 31, 2019

Let test other polices too before closing the issue!

And the corresponding markdown files, if there are any updates.

@realshuting
Copy link
Member Author

And the corresponding markdown files, if there are any updates.

Missed that, will do.

@realshuting
Copy link
Member Author

Ping @shivdudhani ,
Went through samples/more, we are all good, and docs are in sync.

@realshuting realshuting merged commit 2d022d4 into 518_pod_controller Jan 2, 2020
@realshuting realshuting deleted the 371_omitempty branch January 2, 2020 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants