Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve cli help message #5843

Merged
merged 7 commits into from
Jan 3, 2023
Merged

Conversation

eddycharly
Copy link
Member

Signed-off-by: Charles-Edouard Brétéché charles.edouard@nirmata.com

Explanation

This PR improves cli help messages by not output the docs link in short mode.

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Merging #5843 (05e2b93) into main (a2da811) will not change coverage.
The diff coverage is 45.00%.

@@           Coverage Diff           @@
##             main    #5843   +/-   ##
=======================================
  Coverage   35.28%   35.28%           
=======================================
  Files         190      190           
  Lines       21093    21093           
=======================================
  Hits         7442     7442           
  Misses      12834    12834           
  Partials      817      817           
Impacted Files Coverage Δ
pkg/background/generate/generate.go 0.00% <0.00%> (ø)
pkg/engine/utils/utils.go 14.28% <ø> (+2.38%) ⬆️
pkg/webhooks/resource/generation/generation.go 0.00% <0.00%> (ø)
pkg/webhooks/resource/handlers.go 48.17% <0.00%> (ø)
pkg/utils/kube/unstructured.go 33.33% <12.50%> (-8.98%) ⬇️
cmd/cli/kubectl-kyverno/apply/report.go 71.27% <100.00%> (ø)
cmd/cli/kubectl-kyverno/utils/common/common.go 17.65% <100.00%> (ø)
cmd/cli/kubectl-kyverno/utils/common/fetch.go 7.16% <100.00%> (ø)
pkg/clients/dclient/client.go 42.85% <100.00%> (ø)
pkg/utils/admission/resource.go 33.33% <100.00%> (ø)
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

cmd/cli/kubectl-kyverno/jp/jp.go Outdated Show resolved Hide resolved
cmd/cli/kubectl-kyverno/jp/jp.go Outdated Show resolved Hide resolved
Signed-off-by: shuting <shutting06@gmail.com>
Signed-off-by: shuting <shutting06@gmail.com>
@realshuting realshuting enabled auto-merge (squash) January 3, 2023 11:08
@realshuting realshuting merged commit e25bb7e into kyverno:main Jan 3, 2023
@realshuting
Copy link
Member

/cherry-pick release-1.9

gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Jan 3, 2023
* fix: improve cli help message

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* Update cmd/cli/kubectl-kyverno/jp/jp.go

Signed-off-by: shuting <shutting06@gmail.com>

* Update cmd/cli/kubectl-kyverno/jp/jp.go

Signed-off-by: shuting <shutting06@gmail.com>

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Signed-off-by: shuting <shutting06@gmail.com>
Co-authored-by: shuting <shutting06@gmail.com>
@realshuting realshuting added the cherry-pick-completed The PR was cherry-picked (or merged) to required release branches label Jan 3, 2023
realshuting added a commit that referenced this pull request Jan 3, 2023
* fix: improve cli help message

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* Update cmd/cli/kubectl-kyverno/jp/jp.go

Signed-off-by: shuting <shutting06@gmail.com>

* Update cmd/cli/kubectl-kyverno/jp/jp.go

Signed-off-by: shuting <shutting06@gmail.com>

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Signed-off-by: shuting <shutting06@gmail.com>
Co-authored-by: shuting <shutting06@gmail.com>

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Signed-off-by: shuting <shutting06@gmail.com>
Co-authored-by: Charles-Edouard Brétéché <charled.breteche@gmail.com>
Co-authored-by: shuting <shutting06@gmail.com>
MdSahil-oss pushed a commit to MdSahil-oss/kyverno that referenced this pull request Jan 11, 2023
* fix: improve cli help message

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* Update cmd/cli/kubectl-kyverno/jp/jp.go

Signed-off-by: shuting <shutting06@gmail.com>

* Update cmd/cli/kubectl-kyverno/jp/jp.go

Signed-off-by: shuting <shutting06@gmail.com>

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Signed-off-by: shuting <shutting06@gmail.com>
Co-authored-by: shuting <shutting06@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
MdSahil-oss pushed a commit to MdSahil-oss/kyverno that referenced this pull request Jan 11, 2023
* fix: improve cli help message

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* Update cmd/cli/kubectl-kyverno/jp/jp.go

Signed-off-by: shuting <shutting06@gmail.com>

* Update cmd/cli/kubectl-kyverno/jp/jp.go

Signed-off-by: shuting <shutting06@gmail.com>

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Signed-off-by: shuting <shutting06@gmail.com>
Co-authored-by: shuting <shutting06@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-completed The PR was cherry-picked (or merged) to required release branches cherry-pick-required milestone 1.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants