Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing kuttl assert file #5870

Merged
merged 4 commits into from
Jan 5, 2023

Conversation

realshuting
Copy link
Member

Signed-off-by: ShutingZhao shuting@nirmata.com

Explanation

Follow-up PR to add missing kuttl assert file, reference #5866 (comment).

Signed-off-by: ShutingZhao <shuting@nirmata.com>
@realshuting
Copy link
Member Author

/cherry-pick release-1.9

@chipzoller
Copy link
Member

Suggest also adding an errors file that checks the other, non-matching Pod was NOT mutated. That will give us a clear picture.

@realshuting realshuting added this to the Kyverno Release 1.9.0 milestone Jan 4, 2023
@realshuting
Copy link
Member Author

Suggest also adding an errors file that checks the other, non-matching Pod was NOT mutated. That will give us a clear picture.

Sure, I'll make the change.

@codecov
Copy link

codecov bot commented Jan 4, 2023

Codecov Report

Merging #5870 (2dbc8c9) into main (8f14041) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #5870   +/-   ##
=======================================
  Coverage   35.67%   35.67%           
=======================================
  Files         188      188           
  Lines       20853    20853           
=======================================
  Hits         7440     7440           
  Misses      12595    12595           
  Partials      818      818           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@realshuting
Copy link
Member Author

Suggest also adding an errors file that checks the other, non-matching Pod was NOT mutated. That will give us a clear picture.

Sure, I'll make the change.

@chipzoller - added, please take a look.

@realshuting realshuting merged commit e9f338d into kyverno:main Jan 5, 2023
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Jan 5, 2023
Signed-off-by: ShutingZhao <shuting@nirmata.com>

Signed-off-by: ShutingZhao <shuting@nirmata.com>
@realshuting realshuting added the cherry-pick-completed The PR was cherry-picked (or merged) to required release branches label Jan 5, 2023
realshuting added a commit that referenced this pull request Jan 5, 2023
Signed-off-by: ShutingZhao <shuting@nirmata.com>

Signed-off-by: ShutingZhao <shuting@nirmata.com>

Signed-off-by: ShutingZhao <shuting@nirmata.com>
Co-authored-by: shuting <shuting@nirmata.com>
@realshuting realshuting deleted the fix_kuttl_test branch January 9, 2023 12:54
MdSahil-oss pushed a commit to MdSahil-oss/kyverno that referenced this pull request Jan 11, 2023
Signed-off-by: ShutingZhao <shuting@nirmata.com>

Signed-off-by: ShutingZhao <shuting@nirmata.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
MdSahil-oss pushed a commit to MdSahil-oss/kyverno that referenced this pull request Jan 11, 2023
Signed-off-by: ShutingZhao <shuting@nirmata.com>

Signed-off-by: ShutingZhao <shuting@nirmata.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-completed The PR was cherry-picked (or merged) to required release branches cherry-pick-required milestone 1.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants