Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: simplify tests workflow #5920

Merged
merged 7 commits into from
Jan 6, 2023
Merged

Conversation

eddycharly
Copy link
Member

Signed-off-by: Charles-Edouard Brétéché charles.edouard@nirmata.com

Explanation

This PR simplifies tests workflow:

  • moves things in makefile
  • merge both jobs together

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
@codecov
Copy link

codecov bot commented Jan 6, 2023

Codecov Report

Merging #5920 (40d6669) into main (7ab9d95) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #5920   +/-   ##
=======================================
  Coverage   35.85%   35.85%           
=======================================
  Files         188      188           
  Lines       20954    20954           
=======================================
  Hits         7513     7513           
  Misses      12614    12614           
  Partials      827      827           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

eddycharly and others added 2 commits January 6, 2023 14:51
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
@eddycharly eddycharly marked this pull request as ready for review January 6, 2023 13:52
@realshuting realshuting enabled auto-merge (squash) January 6, 2023 14:07
@realshuting
Copy link
Member

@eddycharly - do we need to remove pre-check from branch protection?

@eddycharly
Copy link
Member Author

@realshuting yes we will need to update branch protection to get this in

@realshuting
Copy link
Member

@realshuting yes we will need to update branch protection to get this in

done

@realshuting realshuting merged commit d84ce8f into kyverno:main Jan 6, 2023
@eddycharly eddycharly deleted the gh-actions-9 branch January 6, 2023 20:45
@eddycharly
Copy link
Member Author

/cherry-pick release-1.9

@gcp-cherry-pick-bot
Copy link

Cherry-pick failed with Merge error d84ce8f9d948349359685b5ec5f82e16a7a26199 into temp-cherry-pick-8f4132-release-1.9

@eddycharly
Copy link
Member Author

/cherry-pick release-1.9

MdSahil-oss pushed a commit to MdSahil-oss/kyverno that referenced this pull request Jan 11, 2023
* chore: simplify tests workflow

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* makefile

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
MdSahil-oss pushed a commit to MdSahil-oss/kyverno that referenced this pull request Jan 11, 2023
* chore: simplify tests workflow

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* makefile

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
realshuting pushed a commit to realshuting/kyverno that referenced this pull request Jan 13, 2023
Signed-off-by: ShutingZhao <shuting@nirmata.com>
@realshuting realshuting added the cherry-pick-completed The PR was cherry-picked (or merged) to required release branches label Jan 13, 2023
realshuting added a commit that referenced this pull request Jan 13, 2023
Signed-off-by: ShutingZhao <shuting@nirmata.com>

Signed-off-by: ShutingZhao <shuting@nirmata.com>
Co-authored-by: Charles-Edouard Brétéché <charled.breteche@gmail.com>
MdSahil-oss pushed a commit to MdSahil-oss/kyverno that referenced this pull request Jan 13, 2023
* chore: simplify tests workflow

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* makefile

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-completed The PR was cherry-picked (or merged) to required release branches cherry-pick-required milestone 1.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants