chore: policy report - improve logging

[realshuting]

Signed-off-by: ShutingZhao shuting@nirmata.com

Explanation

This PR logs out a message for the current configured background scan interval.

It doesn't address item 1 from #5933 as we simply re-queue the report with the background scan interval. That means, we don't know how the reconciliation is triggered.

1. that the background scan interval has been reached and a scan is taking place

Related issue

Closes #5933.

Milestone of this PR

/1.9.0

What type of PR is this

/enhancement

Proposed Changes

Proof Manifests

Checklist

• I have read the contributing guidelines.
• I have read the PR documentation guide and followed the process including adding proof manifests to this PR.
• This is a bug fix and I have added unit tests that prove my fix is effective.
• This is a feature and I have added CLI tests that are applicable.
• My PR needs to be cherry picked to a specific release branch which is .
• My PR contains new or altered behavior to Kyverno and
  • CLI support should be added and my PR doesn't contain that functionality.
  • I have added or changed the documentation myself in an existing PR and the link is:
  • I have raised an issue in kyverno/website to track the documentation update and the link is:

Further Comments

[realshuting]

/cherry-pick release-1.9

[codecov]

Codecov Report

Merging #5941 (e69ff0d) into main (6ce8e16) will increase coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head e69ff0d differs from pull request most recent head e37974f. Consider uploading reports for the commit e37974f to get more accurate results

@@            Coverage Diff             @@
##             main    #5941      +/-   ##
==========================================
+ Coverage   35.71%   35.72%   +0.01%     
==========================================
  Files         188      188              
  Lines       21043    21031      -12     
==========================================
- Hits         7515     7513       -2     
+ Misses      12699    12691       -8     
+ Partials      829      827       -2     

Impacted Files	Coverage Δ
pkg/config/config.go	0.00% <0.00%> (ø)
pkg/engine/jmespath/functions.go	71.81% <0.00%> (-1.41%)	⬇️
api/kyverno/v2alpha1/policy_exception_types.go	0.00% <0.00%> (ø)
api/kyverno/v2alpha1/cleanup_policy_types.go	53.84% <0.00%> (+4.69%)	⬆️
api/kyverno/v2beta1/match_resources_types.go	62.50% <0.00%> (+18.38%)	⬆️
api/kyverno/v1/user_info_types.go	64.28% <0.00%> (+19.28%)	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[eddycharly]

Does it work ???

[realshuting]

Does it work ???

Can you elaborate? What do you mean?

[eddycharly]

Did you see the expected log ?

[realshuting]

Did you see the expected log ?

Nope :(

[realshuting]

I don't see any of these logs, why it doesn't work? @eddycharly

[eddycharly]

Calls to V() are cumulative. You are not setting 2 but adding 2.

[realshuting]

Calls to V() are cumulative. You are not setting 2 but adding 2.

@eddycharly - I found a bunch of other logs are not setting the verbosity level and directly uses it, for example, this message:

kyverno/pkg/controllers/openapi/utils.go

Line 8 in 5c71d38

logger.V(6).Info("runtime error", "msg", err.Error())

Are they not printed?

[eddycharly]

This is suspicious. It’s adding 6 to the current level.

[realshuting]

This is suspicious. It’s adding 6 to the current level.

Updated the PR, I also removed un-used paras. Please take a look @eddycharly .

[gcp-cherry-pick-bot]

Cherry-pick failed with Merge error e323e693b267e5b51d893a55b11de415ce9a06ef into temp-cherry-pick-0cdb0e-release-1.9

[chipzoller]

I'm not able to see in this PR what's being logged regarding the issue that it closes for background scans using that flag.

[realshuting]

This PR logs out a message for the current configured background scan interval.

This PR logs out a message for the current configured background scan interval here which is configured via the backgroundScanInterval flag.

[chipzoller]

I see. And is it logging that a background scan is occurring at all? That was the other portion.

[realshuting]

No, please take a look at the PR explanation:

It doesn't address item 1 from #5933 as we simply re-queue the report with the background scan interval. That means, we don't know how the reconciliation is triggered.

1. that the background scan interval has been reached and a scan is taking place

[chipzoller]

So is there a plan to log this info? I feel it's pretty basic information.

[realshuting]

So is there a plan to log this info? I feel it's pretty basic information.

The current logic doesn't work as before, we could only add a message when we re-queue it (with the delay) as I did here. But I found it quite noisy so removed it.

[chipzoller]

Ok