Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update policy exception CRD description #5948

Merged
merged 2 commits into from
Jan 9, 2023
Merged

fix: update policy exception CRD description #5948

merged 2 commits into from
Jan 9, 2023

Conversation

realshuting
Copy link
Member

Explanation

This PR updates policyExcetion CRD description.

Related issue

Closes #5945.

Milestone of this PR

/1.9.0

What type of PR is this

/bug

Proposed Changes

Proof Manifests

Checklist

  • I have read the contributing guidelines.
  • I have read the PR documentation guide and followed the process including adding proof manifests to this PR.
  • This is a bug fix and I have added unit tests that prove my fix is effective.
  • This is a feature and I have added CLI tests that are applicable.
  • My PR needs to be cherry picked to a specific release branch which is .
  • My PR contains new or altered behavior to Kyverno and
    • CLI support should be added and my PR doesn't contain that functionality.
    • I have added or changed the documentation myself in an existing PR and the link is:
    • I have raised an issue in kyverno/website to track the documentation update and the link is:

Further Comments

@realshuting
update exception crds
63f87af 
Signed-off-by: ShutingZhao <shuting@nirmata.com>
@realshuting
update api doc
68d765a 
Signed-off-by: ShutingZhao <shuting@nirmata.com>
@realshuting realshuting enabled auto-merge (squash) January 9, 2023 15:04
@realshuting
Copy link
Member Author

/cherry-pick release-1.9

@realshuting realshuting merged commit 6ce8e16 into kyverno:main Jan 9, 2023
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Jan 9, 2023
@realshuting
fix: update policy exception CRD description (#5948)
db083a9 
* update exception crds

Signed-off-by: ShutingZhao <shuting@nirmata.com>

* update api doc

Signed-off-by: ShutingZhao <shuting@nirmata.com>

Signed-off-by: ShutingZhao <shuting@nirmata.com>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this pull request Jan 9, 2023
Merged
@realshuting realshuting added the cherry-pick-completed The PR was cherry-picked (or merged) to required release branches label Jan 9, 2023
realshuting added a commit that referenced this pull request Jan 9, 2023
@gcp-cherry-pick-bot @realshuting
fix: update policy exception CRD description (#5948) (#5951)
db14bae 
* update exception crds

Signed-off-by: ShutingZhao <shuting@nirmata.com>

* update api doc

Signed-off-by: ShutingZhao <shuting@nirmata.com>

Signed-off-by: ShutingZhao <shuting@nirmata.com>

Signed-off-by: ShutingZhao <shuting@nirmata.com>
Co-authored-by: shuting <shuting@nirmata.com>
@realshuting realshuting deleted the update_pexception_description branch January 9, 2023 16:52
MdSahil-oss pushed a commit to MdSahil-oss/kyverno that referenced this pull request Jan 11, 2023
@realshuting @MdSahil-oss
fix: update policy exception CRD description (kyverno#5948)
d445601 
* update exception crds

Signed-off-by: ShutingZhao <shuting@nirmata.com>

* update api doc

Signed-off-by: ShutingZhao <shuting@nirmata.com>

Signed-off-by: ShutingZhao <shuting@nirmata.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
MdSahil-oss pushed a commit to MdSahil-oss/kyverno that referenced this pull request Jan 11, 2023
@realshuting @MdSahil-oss
fix: update policy exception CRD description (kyverno#5948)
5efeb48 
* update exception crds

Signed-off-by: ShutingZhao <shuting@nirmata.com>

* update api doc

Signed-off-by: ShutingZhao <shuting@nirmata.com>

Signed-off-by: ShutingZhao <shuting@nirmata.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
MdSahil-oss pushed a commit to MdSahil-oss/kyverno that referenced this pull request Jan 13, 2023
@realshuting @MdSahil-oss
fix: update policy exception CRD description (kyverno#5948)
f715b4b 
* update exception crds

Signed-off-by: ShutingZhao <shuting@nirmata.com>

* update api doc

Signed-off-by: ShutingZhao <shuting@nirmata.com>

Signed-off-by: ShutingZhao <shuting@nirmata.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chipzoller chipzoller chipzoller approved these changes

@treydock treydock Awaiting requested review from treydock treydock is a code owner

@eddycharly eddycharly Awaiting requested review from eddycharly eddycharly is a code owner

@prateekpandey14 prateekpandey14 Awaiting requested review from prateekpandey14

Assignees
No one assigned
Labels
cherry-pick-completed The PR was cherry-picked (or merged) to required release branches cherry-pick-required milestone 1.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[PolicyExceptions] CRD description isnt verbose enough to use
2 participants
@realshuting @chipzoller