fix: invoke cleanup process during shutdown #5974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ShutingZhao <shuting@nirmata.com>
Codecov Report
@@ Coverage Diff @@
## main #5974 +/- ##
==========================================
- Coverage 35.93% 35.89% -0.04%
==========================================
Files 192 192
Lines 21037 21060 +23
==========================================
Hits 7560 7560
- Misses 12643 12666 +23
Partials 834 834
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: ShutingZhao <shuting@nirmata.com>
realshuting
requested review from
eddycharly
and removed request for
prateekpandey14
Signed-off-by: ShutingZhao <shuting@nirmata.com>
Signed-off-by: ShutingZhao <shuting@nirmata.com>
|
/cherry-pick release-1.9 |
2 tasks
eddycharly
reviewed
Jan 11, 2023
Comment on lines
+17
to
+18
| ManagedByLabel = "webhook.kyverno.io/managed-by" | ||
| KyvernoComponentLabel = "app.kubernetes.io/component" |
There was a problem hiding this comment.
Not sure it's the best place to define those new const.
Not a blocker, we can change later.
eddycharly
approved these changes
Jan 11, 2023
Yes, both scaling down to zero and helm uninstall:) |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Jan 12, 2023
* invoke cleanup process during shutdown Signed-off-by: ShutingZhao <shuting@nirmata.com> * fix shutdown cleanup Signed-off-by: ShutingZhao <shuting@nirmata.com> * fix shutdown panic Signed-off-by: ShutingZhao <shuting@nirmata.com> * cleanup webhooks by the label Signed-off-by: ShutingZhao <shuting@nirmata.com> Signed-off-by: ShutingZhao <shuting@nirmata.com> Co-authored-by: Charles-Edouard Brétéché <charled.breteche@gmail.com>
realshuting
added
the
cherry-pick-completed
realshuting
added a commit
that referenced
this pull request
Jan 12, 2023
* invoke cleanup process during shutdown Signed-off-by: ShutingZhao <shuting@nirmata.com> * fix shutdown cleanup Signed-off-by: ShutingZhao <shuting@nirmata.com> * fix shutdown panic Signed-off-by: ShutingZhao <shuting@nirmata.com> * cleanup webhooks by the label Signed-off-by: ShutingZhao <shuting@nirmata.com> Signed-off-by: ShutingZhao <shuting@nirmata.com> Co-authored-by: Charles-Edouard Brétéché <charled.breteche@gmail.com> Signed-off-by: ShutingZhao <shuting@nirmata.com> Co-authored-by: shuting <shuting@nirmata.com> Co-authored-by: Charles-Edouard Brétéché <charled.breteche@gmail.com>
MdSahil-oss
pushed a commit
to MdSahil-oss/kyverno
that referenced
this pull request
Jan 13, 2023
* invoke cleanup process during shutdown Signed-off-by: ShutingZhao <shuting@nirmata.com> * fix shutdown cleanup Signed-off-by: ShutingZhao <shuting@nirmata.com> * fix shutdown panic Signed-off-by: ShutingZhao <shuting@nirmata.com> * cleanup webhooks by the label Signed-off-by: ShutingZhao <shuting@nirmata.com> Signed-off-by: ShutingZhao <shuting@nirmata.com> Co-authored-by: Charles-Edouard Brétéché <charled.breteche@gmail.com> Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ShutingZhao shuting@nirmata.com
Explanation
This PR cleans up Kyverno managed resources (leases, *webhookconfigurations) and fixes the shutdown panic. The webhooks' owner is set to clusterrole
kyverno:webhookto deal with Helm uninstall where kyverno lost permission to perform such cleanup.Related issue
Closes #5942.
Closes #5355.
Milestone of this PR
/1.9.0
What type of PR is this
/bug
Proposed Changes
Proof Manifests
Checklist
Further Comments