fix: generate policy exception events #5987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
|
/cherry-pick release-1.9 |
chipzoller
reviewed
Jan 12, 2023
realshuting
reviewed
Jan 12, 2023
pkg/event/events.go
Outdated
| Name: exceptionName, | ||
| Namespace: exceptionNamespace, | ||
| Reason: PolicySkipped.String(), | ||
| Message: messageBuilder.String(), |
There was a problem hiding this comment.
Can we also add policy information?
There was a problem hiding this comment.
Good catch ! Will fix soon.
Codecov Report
@@ Coverage Diff @@
## main #5987 +/- ##
=======================================
Coverage 35.86% 35.87%
=======================================
Files 193 193
Lines 21078 21075 -3
=======================================
Hits 7560 7560
+ Misses 12684 12681 -3
Partials 834 834
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
realshuting
approved these changes
Jan 13, 2023
|
Cherry-pick failed with |
eddycharly
added a commit
to eddycharly/kyverno
that referenced
this pull request
Jan 13, 2023
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
realshuting
added
the
cherry-pick-completed
eddycharly
added a commit
that referenced
this pull request
Jan 13, 2023
MdSahil-oss
pushed a commit
to MdSahil-oss/kyverno
that referenced
this pull request
Jan 13, 2023
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Charles-Edouard Brétéché charles.edouard@nirmata.com
Explanation
This PR fixes policy exception events.