fix: ns labels matching #6020
Merged
fix: ns labels matching #6020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ShutingZhao <shuting@nirmata.com>
realshuting
requested review from
eddycharly
and removed request for
prateekpandey14
Codecov Report
@@ Coverage Diff @@
## main #6020 +/- ##
=======================================
Coverage 35.82% 35.83%
=======================================
Files 193 193
Lines 21114 21115 +1
=======================================
+ Hits 7565 7566 +1
Misses 12713 12713
Partials 836 836
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: ShutingZhao <shuting@nirmata.com>
Signed-off-by: ShutingZhao <shuting@nirmata.com>
|
/cherry-pick release-1.9 |
eddycharly
reviewed
Jan 18, 2023
| @@ -0,0 +1,4 @@ | |||
| apiVersion: kuttl.dev/v1beta1 | |||
There was a problem hiding this comment.
You don't need this anymore, our kuttl fork cleans up resources
|
@realshuting can you use |
Signed-off-by: ShutingZhao <shuting@nirmata.com>
Updated! |
eddycharly
approved these changes
Jan 18, 2023
|
Cherry-pick failed with |
realshuting
added
the
cherry-pick-completed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ShutingZhao shuting@nirmata.com
Explanation
Fixed namespace selector matching in wildcard policies.
Related issue
Closes #6015.
Milestone of this PR
/1.9.0
What type of PR is this
/bug
Proposed Changes
Proof Manifests
Checklist
Further Comments