fix: replace + with _ in Chart.Version label field #6047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening your first Pull Request here! Please check out our Contributing guidelines and confirm that you Signed off. |
Signed-off-by: Linda Arende <lda.ext@velux.com>
LindaArende
force-pushed
the
fix-invalid-chart-version-label
branch
from
bc81dd7
to
4d6aa10
Compare
eddycharly
added
cherry-pick-required
milestone 1.9.0
and removed
milestone 1.10.0
labels
eddycharly
approved these changes
Jan 19, 2023
Codecov Report
@@ Coverage Diff @@
## main #6047 +/- ##
=======================================
Coverage 36.02% 36.02%
=======================================
Files 193 193
Lines 21006 21006
=======================================
Hits 7567 7567
Misses 12604 12604
Partials 835 835 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
/cherry-pick release-1.9 |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Jan 19, 2023
Signed-off-by: Linda Arende <lda.ext@velux.com> Signed-off-by: Linda Arende <lda.ext@velux.com> Co-authored-by: Linda Arende <lda.ext@velux.com>
eddycharly
added
the
cherry-pick-completed
eddycharly
pushed a commit
that referenced
this pull request
Jan 19, 2023
Signed-off-by: Linda Arende <lda.ext@velux.com> Signed-off-by: Linda Arende <lda.ext@velux.com> Co-authored-by: Linda Arende <lda.ext@velux.com> Signed-off-by: Linda Arende <lda.ext@velux.com> Co-authored-by: Linda Ārende <64084638+LindaArende@users.noreply.github.com> Co-authored-by: Linda Arende <lda.ext@velux.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed off by: Linda Ārende linda.arende@gmail.com
This suggestion is directly linked to this PR and solves the same issue.
Explanation
When using Flux the Chart version number can contain the plus symbol (+).
This is not an allowed for label field value and therefore fails reconciliation.
The PR replaces plus symbol with underscore.
What type of PR is this
/kind bug