fix: tls cipher suites #7308
Merged
fix: tls cipher suites #7308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
realshuting
approved these changes
May 26, 2023
|
/cherry-pick release-1.10 |
chipzoller
reviewed
May 26, 2023
There was a problem hiding this comment.
NMAP reports 11 ciphers currently
| TLS_ECDHE_RSA_WITH_3DES_EDE_CBC_SHA (secp256r1) - C
| TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA (secp256r1) - A
| TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (secp256r1) - A
| TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA (secp256r1) - A
| TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (secp256r1) - A
| TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256 (secp256r1) - A
| TLS_RSA_WITH_3DES_EDE_CBC_SHA (rsa 2048) - C
| TLS_RSA_WITH_AES_128_CBC_SHA (rsa 2048) - A
| TLS_RSA_WITH_AES_128_GCM_SHA256 (rsa 2048) - A
| TLS_RSA_WITH_AES_256_CBC_SHA (rsa 2048) - A
| TLS_RSA_WITH_AES_256_GCM_SHA384 (rsa 2048) - A
Excluding the undesirable 3DES ones, that would still make 9. You have 6 listed. What was the decision to not include the other 3?
The linter marks them as not safe. |
|
Ok |
Codecov Report
@@ Coverage Diff @@
## main #7308 +/- ##
=======================================
Coverage 33.97% 33.97%
=======================================
Files 226 226
Lines 22000 22000
=======================================
Hits 7475 7475
Misses 13802 13802
Partials 723 723 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
May 26, 2023
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> Co-authored-by: shuting <shuting@nirmata.com>
|
/cherry-pick release-1.9 |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
May 26, 2023
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> Co-authored-by: shuting <shuting@nirmata.com>
eddycharly
added
cherry-pick-completed
eddycharly
added a commit
that referenced
this pull request
May 26, 2023
realshuting
added a commit
that referenced
this pull request
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR fixes tls cipher suites.